This repository was archived by the owner on Feb 16, 2023. It is now read-only.
Add temporary tests to run command#246
Merged
SimonBarendse merged 1 commit intodevelopfrom Feb 21, 2020
Merged
Conversation
These tests do not follow best practices and have a low quality since they will only be used to lower the risk of introducing new bugs in a refactoring that will follow shortly. After the code is refactored these tests will be rewritten.
SimonBarendse
approved these changes
Feb 21, 2020
Member
SimonBarendse
left a comment
SimonBarendse
left a comment
There was a problem hiding this comment.
Sweet! This was long due :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To increase testability, the
secrethub runcommand's code will be refactored.In order to decrease the risk of introducing new bugs during this procedure, some temporary tests have been added that verify most of the main functionality of the command.
These tests will be rewritten after the refactor, to better follow testing guidelines.