Skip to content
This repository was archived by the owner on Feb 16, 2023. It is now read-only.

GCP Identity Provider#292

Merged
jpcoenen merged 13 commits intodevelopfrom
feature/gcp-idp
Jun 5, 2020
Merged

GCP Identity Provider#292
jpcoenen merged 13 commits intodevelopfrom
feature/gcp-idp

Conversation

@jpcoenen
Copy link
Copy Markdown
Member

@jpcoenen jpcoenen commented Jun 3, 2020

Adds a new credential type for GCP Service Account, which allows a service running on GCP to use keyless authentication.

Introduces a new (currently hidden) secrethub service gcp subcommand and allows gcp as an Identity Provider.

Please note: this feature starts in private beta. By default, it will not be enabled on your namespace. If you want to give it a try, reach out to us at support@secrethub.io.

@jpcoenen jpcoenen requested a review from SimonBarendse June 3, 2020 11:55
Copy link
Copy Markdown
Member

@SimonBarendse SimonBarendse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good 👍

Just found one piece of logic that isn't clear to me yet (see comment), could you clarify this for me?


This PR mentions "private beta" status and hides the command in the help text.

Have we already considered how we want to communicate the "private beta" state to the user? I believe the most important aspect of this is being clear about what users can expect with regards to stability and backwards-compatibility of the feature.

You've already addressed this state in this PR's description. Do we want to expand that message with the expectations a user can have of "private beta" features?

When the PR follows its way into production, we can continue to share this message along the way, for example in:

  • In this PRs description
  • In release notes
  • In documentation (including help texts)
  • When using it (e.g. print a warning on stderr)

If we haven't formed a strategy around this yet: shall we have a quick brainstorm?

Comment thread internals/secrethub/service_gcp_init.go
It is still in private beta, listing it would be confusing.
Copy link
Copy Markdown
Member

@SimonBarendse SimonBarendse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpcoenen jpcoenen merged commit 3728d34 into develop Jun 5, 2020
@jpcoenen jpcoenen deleted the feature/gcp-idp branch June 5, 2020 09:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants