clang-tidy: Identifier rename ControlFlow#452
Merged
pdschubert merged 5 commits intodevelopmentfrom Jan 4, 2022
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…tegy, PhasarClang
vulder
force-pushed
the
f-ClangTidyIdentifierRenameControlFlow
branch
from
6279a2b to
8efefad
Compare
vulder
requested changes
Dec 26, 2021
Comment on lines
+36
to
+37
| ICFGPlugin(ProjectIRDB &IRDB, const std::vector<std::string> &EntryPoints) | ||
| : IRDB(IRDB), EntryPoints(EntryPoints) {} |
Collaborator
There was a problem hiding this comment.
Why would we not move the EntryPoints here?
Suggested change
| ICFGPlugin(ProjectIRDB &IRDB, const std::vector<std::string> &EntryPoints) | |
| : IRDB(IRDB), EntryPoints(EntryPoints) {} | |
| ICFGPlugin(ProjectIRDB &IRDB, std::vector<std::string> EntryPoints) | |
| : IRDB(IRDB), EntryPoints(std::move(EntryPoints)) {} |
| } | ||
|
|
||
| auto getConstantBitcastArgument = [](llvm::Value *V) -> llvm::Value * { | ||
| auto getConstantBitcastArgument = // NOLINT |
Comment on lines
+949
to
951
| // auto It = | ||
| GlobalDtors.emplace(0, RegisteredDtorCaller); | ||
| // GlobalDtorFn.try_emplace(RegisteredDtorCaller, it); |
Collaborator
There was a problem hiding this comment.
Remove the commented code?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
please merge after #451