clang-tidy: Identifier rename IfdsIde FF/EF#453
Merged
pdschubert merged 4 commits intodevelopmentfrom Jan 4, 2022
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
vulder
force-pushed
the
f-ClangTidyIdentifierRenameIfdsIdeFFEF
branch
from
245cae1 to
44c0630
Compare
…tonFactoryTest.cpp Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
vulder
requested changes
Dec 26, 2021
| static std::map<N, std::set<D>> make(std::vector<N> Nodes, D ZeroNode) { | ||
| std::map<N, std::set<D>> Result; | ||
| for (N Node : Nodes) { | ||
| Result.insert(Node, {ZeroNode}); |
Collaborator
There was a problem hiding this comment.
As we have copied the Nodes vector already, we should move the elements into the map.
Suggested change
| Result.insert(Node, {ZeroNode}); | |
| Result.insert(std::move(Node), {ZeroNode}); |
| const unsigned EFComposer_Id; | ||
| static inline unsigned CurrEFComposer_Id = 0; | ||
| const unsigned EFComposerId; | ||
| static inline unsigned CurrEFComposerId = 0; // NOLINT |
Member
There was a problem hiding this comment.
Variable 'CurrEfComposerId' is non-const and globally accessible, consider making it constclang-tidy(cppcoreguidelines-avoid-non-const-global-variables)
Comment on lines
+19
to
20
| : EdgeFunctionComposer<int>(F, G){}; | ||
| std::shared_ptr<EdgeFunction<int>> |
Collaborator
There was a problem hiding this comment.
Suggested change
| : EdgeFunctionComposer<int>(F, G){}; | |
| std::shared_ptr<EdgeFunction<int>> | |
| : EdgeFunctionComposer<int>(F, G){}; | |
| std::shared_ptr<EdgeFunction<int>> |
An empty line here would make it more readable ;)
PS: Why did you remove the moves?
pdschubert
approved these changes
Jan 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
please merge after #452