Remove deprecated SSlibSigner and from/to_securesystemslib_key methods #771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 10, 2024 16:23
Use CrytpoSigners loaded from test key files instead of SSlibSigners created from ad-hoc generated keys. This allows removing the deprecated SSlibSigner and legacy key generation interface, and is faster. Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
In preparation for the removal of SSlibSigner, the following SSlibSigner-specific tests are removed from TestSigner: - "file" and "envvar" uri tests - init tests In addition, tests, which use SSlibSigner, are ported from TestSigner to TestCryptoSigner: - "sign with all schemes" tests - "custom signer" tests Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the deprecated SSlibSigner.
CryptoSigner can be used as replacement.
The most interesting (review-worthy) bits of this PR are the two initial test change commits.
In addition, this PR removes three deprecated / obsolete translation methods between Signer API objects and the legacy secureysystemslib key dictionary format. These are not directly related to SSlibSigner but still need to be removed as part of #731.