Remove legacy key modules, tests and references #772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 10, 2024
added 5 commits
April 12, 2024 11:12
With the upcoming removal of legacy interfaces and related tests, the ratio of tested to untested code changes significantly. This does not mean that the test coverage of the Signer API decreases! Also note that overall test coverage might be higher (see secure-systems-lab#208). Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
The Signer API provides a more powerful and modern replacement. Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
With the removal of legacy key modules, some custom exception classes are no longer needed. Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
With the removal of legacy key modules, settings is no longer used or needed. fixes secure-systems-lab#219 Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
pynacl was used in legacy key modules, in addition to pyca/cryptography, for its ed25519 implementation. The replacement CryptoSigner only depends on pyca/cryptography, which implements all needed key types (including ed25519). Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
jku
approved these changes
Apr 15, 2024
Collaborator
jku
left a comment
jku
left a comment
There was a problem hiding this comment.
looks as I expected so I guess it's good to go?
I guess the best way to find out is to
- merge these changes
- create a python-tuf branch that works with securesystemslib main
- make sure nothing breaks
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocks on #771 (commits are included in this PR)closes #172, closes #219, closes #280, closes #286, closes #309, closes #310, #477
This PR removes legacy key modules, tests and references. The Signer API provides a more powerful and modern replacement.
In addition, this commit removes custom exception classes, the legacy settings module, and the optional
pynacldependency, which have become obsolete.To account for the significant ratio change of tested to untested code, the CI coverage requirement is lowered. This does not mean that the absolute test coverage of the remaining Signer API decreases by this PR!