Made template for React/Vue comparison + Seed 0.5.0 #2
Conversation
|
Added in some of the 0.5.0 changes. I'm not familiar with how you update some things like the docs-url versions throughout. More 0.5.0 changes probably need to be made too. |
MartinKavik
changed the title
|
@MartinKavik : Can you take a look to make sure I didn't dork something up before deploying? We can add to the comparison later, but I'd like to get the v0.5.0 changes out. I can't get it to build on my end due to not having |
| let app = seed::App::builder(update, view) | ||
| .after_mount(after_mount) | ||
| .run(); | ||
|
|
||
| app.update(Msg::FetchData); |
There was a problem hiding this comment.
Todo for next PRs
In all examples:
seed::Appreplace withAppand make sure we have the lineuse seed::{*, prelude::*}at the top of the example (if necessary) ; And we probably should addAppintoprelude.let app ... app.update(...is anti-pattern. It should be refactored withafter_mount.
There was a problem hiding this comment.
Updated this PR and the Rust quickstart with this import style.
|
@David-OConnor : I've added one comment for the future, but everything looks good.
Could you create an issue in https://github.com/seed-rs/seed-quickstart-webpack and describe your problems? (e.g. what errors
I don't know if the checklist is really needed in this project - maybe we can delete it. An idea - we can add versioning once the Seed is stable (version 1.x.x+), i.e. there will be a dropdown with Seed versions and when you choose a version, associated content will be rendered. |
|
I didn't try anything on the JS end, which is probably the problem. |
A start: seed-rs/seed#208 (comment)