feat: ✨ add guideline for how to review PRs - #394
Merged
Conversation
signekb
approved these changes
Aug 4, 2026
signekb
left a comment
signekb
left a comment
Member
There was a problem hiding this comment.
Nice, I like this 👌 Should it be in the guidebook instead though?
github-project-automation
Bot
moved this from In Review
to Approved
in Product development
Member
Author
|
@signekb at this stage, no. It's too specific to us and too small right now, but maybe as we work with it, it could be revised to be suitable for the guidebook. |
martonvago
approved these changes
Aug 4, 2026
joelostblom
approved these changes
Aug 4, 2026
DanMazJen
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We've started getting PRs that get too much discussions and remain open for too long. The PR mechanism isn't designed for that. So this guideline sets some "limits" to how we use/interact with reviewing PRs.
Needs a thorough review.
Checklist
just run-all