fix(imdbRadarrProxy): pass headers and nodeCache as options instead of params

[fallenbagel]

Description

The IMDBRadarrProxy constructor was passing { headers, nodeCache } as the second argument to super(), which ExternalAPI treats as axios default query parameters rather than options. This meant that our internal IMDB cache was silently dead (never populated, every request hit the network), and every outbound request to api.radarr.video carried ?headers[...]&nodeCache=[object+Object] tacked on. Since that query string is identical across every Seerr instance everywhere, we were all hitting the same mangled URL on Radarr's CDN and getting back whatever stale response had been cached against that key, which is why ratings could drift out of sync with the canonical endpoint for extended periods.

• Fixes Wrong IMDB rating displayed #2899

How Has This Been Tested?

Before the fix, every request from Seerr to api.radarr.video hits a URL with garbage query params appended. You can reproduce the stale response by curling the mangled URL directly:

Mangled URL (what Seerr currently hits) which returns stale cached rating:

curl -s "https://api.radarr.video/v1/movie/imdb/tt36647890?headers%5BContent-Type%5D=application%2Fjson&headers%5BAccept%5D=application%2Fjson&nodeCache=%5Bobject+Object%5D" \
  -H "Accept: application/json" | jq '.[0].MovieRatings.Imdb'

{
  "Count": 203,
  "Value": 4.1,
  "Type": "User"
}

Canonical URL (what we'll hit after the fix) which returns current rating:

curl -s "https://api.radarr.video/v1/movie/imdb/tt36647890" \
  -H "Accept: application/json" | jq '.[0].MovieRatings.Imdb'

{
  "Count": 1683,
  "Value": 3.9,
  "Type": "User"
}

After the fix, hit /api/v1/movie/1470130/ratingscombined on a running instance and confirm imdb.criticsScore matches the canonical curl output (on ui too).

Screenshots / Logs (if applicable)

Checklist:

• I have read and followed the contribution guidelines.
• Disclosed any use of AI (see our policy)
• I have updated the documentation accordingly.
• All new and existing tests passed.
• Successful build pnpm build
• Translation keys pnpm i18n:extract
• Database migration (if required)

Summary by CodeRabbit

• Refactor
  • Internal improvements to code organization for better maintainability.

[coderabbitai]

📝 Walkthrough

Walkthrough

Updated the IMDBRadarrProxy constructor initialization by restructuring the super call parameters. Request headers and cache manager configuration are preserved and repositioned from the second argument into a nested third argument structure, addressing an issue with incorrect IMDB ratings.

Changes

Cohort / File(s)	Summary
IMDB Proxy Constructor server/api/rating/imdbRadarrProxy.ts	Refactored the parent class constructor invocation from single config-object form to multi-parameter form (super(url, {}, { ... })). Preserved request headers (Content-Type, Accept) and nodeCache initialization while reorganizing their placement in the parameter structure.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested reviewers

• gauthier-th
• 0xSysR3ll

Poem

🐰 A proxy fixed with careful care,
Parameters repositioned with flair,
IMDB ratings now align so true,
No more wrong scores in the queue!
Hop along, the bug's now gone! 🍃

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the fix: changing how headers and nodeCache are passed to the parent constructor in IMDBRadarrProxy.
Linked Issues check	✅ Passed	The PR directly addresses issue #2899 by fixing the root cause: headers and nodeCache are now correctly passed as options rather than query parameters, ensuring proper cache population and correct outbound requests.
Out of Scope Changes check	✅ Passed	All changes are scoped to the IMDBRadarrProxy constructor call and directly address the reported issue; no unrelated modifications are present.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

server/api/rating/imdbRadarrProxy.ts (1)

159-169: Fix correctly aligns with ExternalAPI constructor signature.

Passing {} as params and moving headers/nodeCache into the third ExternalAPIOptions argument matches the parent constructor (baseUrl, params, options). This will stop the headers=[object Object]&nodeCache=... garbage query string from being appended to requests (which was colliding with Radarr's CDN cache) and will correctly wire up the imdb NodeCache so repeated lookups no longer hit the network.

Minor nit: Content-Type: application/json and Accept: application/json are already applied by ExternalAPI's constructor defaults (see server/api/externalapi.ts:13-54), so the explicit headers block here is redundant and could be dropped for clarity — not a blocker.

🧹 Optional cleanup

     super(
       'https://api.radarr.video/v1',
       {},
       {
-        headers: {
-          'Content-Type': 'application/json',
-          Accept: 'application/json',
-        },
         nodeCache: cacheManager.getCache('imdb').data,
       }
     );

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@server/api/rating/imdbRadarrProxy.ts` around lines 159 - 169, Update the
super(...) call in the imdbRadarrProxy class constructor to match
ExternalAPI(baseUrl, params, options): pass an explicit params object (e.g. {})
as the second argument and move the headers and nodeCache into the third
argument (ExternalAPIOptions) so headers/nodeCache are not serialized into the
query string; optionally remove the redundant headers block since ExternalAPI
already supplies Content-Type/Accept defaults.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@server/api/rating/imdbRadarrProxy.ts`:
- Around line 159-169: Update the super(...) call in the imdbRadarrProxy class
constructor to match ExternalAPI(baseUrl, params, options): pass an explicit
params object (e.g. {}) as the second argument and move the headers and
nodeCache into the third argument (ExternalAPIOptions) so headers/nodeCache are
not serialized into the query string; optionally remove the redundant headers
block since ExternalAPI already supplies Content-Type/Accept defaults.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 32d84d1e-296d-4097-a62b-c45ebeeaa462

📥 Commits

Reviewing files that changed from the base of the PR and between 51cc0dc and 6265e80.

📒 Files selected for processing (1)

• server/api/rating/imdbRadarrProxy.ts