fix(override-rules): use find() instead of index lookup for service resolution

[fallenbagel]

Description

This PR is fixes a bug in the Override Rules modal where dropdowns (Root Folder, Quality Profile, Tags) would remain greyed out when editing an existing rule or selecting a service. The root cause was that radarrServices and sonarrServices were being looked up by array index using the service ID, which only worked by coincidence when the ID matched the index and most commonly broken after a user deletes and re-adds a service, causing the ID to increment while the array index stays at 0. Replaced the index lookups with .find() to correctly resolve services by their ID.

How Has This Been Tested?

• This has been tested by the reported user and they have confirmed that it works:

Screenshots / Logs (if applicable)

Checklist:

• I have read and followed the contribution guidelines.
• Disclosed any use of AI (see our policy)
• I have updated the documentation accordingly.
• All new and existing tests passed.
• Successful build pnpm build
• Translation keys pnpm i18n:extract
• Database migration (if required)

Summary by CodeRabbit

• Refactor
  • Improved service lookup mechanism in settings to enhance reliability and maintainability.

[coderabbitai]

📝 Walkthrough

Walkthrough

Updated service lookup logic in OverrideRuleModal to use id-based searches via Array.find instead of index-based array access. Changes affect both the initialization useEffect and service selection handlers, triggering getServiceInfos only when a matching service is found by id comparison.

Changes

Cohort / File(s)	Summary
Service Lookup Refactoring src/components/Settings/OverrideRule/OverrideRuleModal.tsx	Replaced index-based service lookups (radarrServices[id], sonarrServices[id]) with id-based Array.find searches; updated initialization useEffect and service selection handler to conditionally trigger getServiceInfos only when matching service objects are found.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A rabbit hops through arrays with glee,
Finding services by their ID,
No more index confusion or dismay,
The right match found the proper way,
Data flows truthy, clean, and bright!

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: replacing index-based service lookups with id-based searches using .find() in the override rules modal.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cypress]

seerr    Run #3372

Run Properties:   Passed #3372  •  46ff243b85: fix(override-rules): use find() instead of index lookup for service resolution

Project	seerr
Branch Review	debug-overriderules
Run status	Passed #3372
Run duration	02m 21s
Commit	46ff243b85: fix(override-rules): use find() instead of index lookup for service resolution
Committer	fallenbagel
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	0
Pending	0
Skipped	0
Passing	32
View all changes introduced in this branch ↗︎

[gauthier-th]

Success

[fallenbagel]

Accidentally closed 😅