Skip to content

test(override-rules): add component tests for service id resolution #2905

Closed
fallenbagel wants to merge 2 commits into
developfrom
cypress-component-testing
Closed

test(override-rules): add component tests for service id resolution #2905
fallenbagel wants to merge 2 commits into
developfrom
cypress-component-testing

Conversation

@fallenbagel
Copy link
Copy Markdown
Member

Description

Caution

This PR must be merged after #2903, as it depends on the fix introduced there.

Adds Cypress component testing infrastructure and a test suite for the OverrideRuleModal component. The CI workflow is extended with a separate parallel job that runs component tests without needing a running server. The test suite covers the service ID resolution bug fixed in the preceding PR #2903

How Has This Been Tested?

Screenshots / Logs (if applicable)

Checklist:

  • I have read and followed the contribution guidelines.
  • Disclosed any use of AI (see our policy)
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • Successful build pnpm build
  • Translation keys pnpm i18n:extract
  • Database migration (if required)

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 18, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 59e6462d-1913-4bd5-ab9a-b9d823d665ee

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cypress
Copy link
Copy Markdown

cypress Bot commented Apr 18, 2026

seerr    Run #3375

Run Properties:  status check passed Passed #3375  •  git commit 08bb6cdc00: test(override-rules): add component tests for service id resolution
Project seerr
Branch Review cypress-component-testing
Run status status check passed Passed #3375
Run duration 02m 29s
Commit git commit 08bb6cdc00: test(override-rules): add component tests for service id resolution
Committer fallenbagel
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 32
View all changes introduced in this branch ↗︎

@fallenbagel
Copy link
Copy Markdown
Member Author

After further consideration, I dont think this brings us much value tbh. Therefore, I am closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant