ci: fix docker login race condition - #3303
Conversation
Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughDocker Hub and GitHub Container Registry login steps were repositioned in CI, preview, and release workflows to run sequentially rather than inside parallel blocks. Authentication actions, versions, and credential sources remain unchanged. ChangesRegistry authentication flow
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…1) (#193) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/seerr-team/seerr](https://github.com/seerr-team/seerr) | patch | `v3.4.0` → `v3.4.1` | --- ### Release Notes <details> <summary>seerr-team/seerr (ghcr.io/seerr-team/seerr)</summary> ### [`v3.4.1`](https://github.com/seerr-team/seerr/releases/tag/v3.4.1) [Compare Source](seerr-team/seerr@v3.4.0...v3.4.1) ##### 🐛 Bug Fixes - *(ui)* Keep user list action buttons sized with a single user ([#​3311](seerr-team/seerr#3311)) - ([f926248](seerr-team/seerr@f926248)) - Don't delete requests when removing media from arr ([#​3288](seerr-team/seerr#3288)) - ([3ee6f92](seerr-team/seerr@3ee6f92)) - Handle already-removed media in radarr/sonarr delete ([#​3209](seerr-team/seerr#3209)) - ([8ea0c17](seerr-team/seerr@8ea0c17)) ##### ⚙️ Miscellaneous Tasks - *(release)* Prepare v3.4.1 - ([69f73a6](seerr-team/seerr@69f73a6)) - *(release)* Prepare v3.4.1 release - ([5c8f1cb](seerr-team/seerr@5c8f1cb)) - Fix docker login race condition ([#​3303](seerr-team/seerr#3303)) - ([95e18de](seerr-team/seerr@95e18de)) - Parallelize the action steps when possible ([#​3225](seerr-team/seerr#3225)) - ([45f7a7a](seerr-team/seerr@45f7a7a)) </details> --- ### Configuration 📅 **Schedule**: (in timezone Europe/Berlin) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4wLjAiLCJ1cGRhdGVkSW5WZXIiOiI0NC4wLjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbInJlbm92YXRlL2NvbnRhaW5lciIsInR5cGUvcGF0Y2giXX0=--> Reviewed-on: https://git.xcd.dev/gabrielcosi/home-ops/pulls/193
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [seerr/seerr](https://github.com/seerr-team/seerr) | patch | `v3.4.0` → `v3.4.1` | --- ### Release Notes <details> <summary>seerr-team/seerr (seerr/seerr)</summary> ### [`v3.4.1`](https://github.com/seerr-team/seerr/releases/tag/v3.4.1) [Compare Source](seerr-team/seerr@v3.4.0...v3.4.1) ##### 🐛 Bug Fixes - *(ui)* Keep user list action buttons sized with a single user ([#​3311](seerr-team/seerr#3311)) - ([f926248](seerr-team/seerr@f926248)) - Don't delete requests when removing media from arr ([#​3288](seerr-team/seerr#3288)) - ([3ee6f92](seerr-team/seerr@3ee6f92)) - Handle already-removed media in radarr/sonarr delete ([#​3209](seerr-team/seerr#3209)) - ([8ea0c17](seerr-team/seerr@8ea0c17)) ##### ⚙️ Miscellaneous Tasks - *(release)* Prepare v3.4.1 - ([69f73a6](seerr-team/seerr@69f73a6)) - *(release)* Prepare v3.4.1 release - ([5c8f1cb](seerr-team/seerr@5c8f1cb)) - Fix docker login race condition ([#​3303](seerr-team/seerr#3303)) - ([95e18de](seerr-team/seerr@95e18de)) - Parallelize the action steps when possible ([#​3225](seerr-team/seerr#3225)) - ([45f7a7a](seerr-team/seerr@45f7a7a)) </details> --- ### Configuration 📅 **Schedule**: (in timezone America/New_York) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4wLjAiLCJ1cGRhdGVkSW5WZXIiOiI0NC4wLjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbInJlbm92YXRlL2NvbnRhaW5lciIsInR5cGUvcGF0Y2giXX0=--> Reviewed-on: https://git.greyrock.io/greyrock-labs/home-ops/pulls/213
Description
It seems that docker login action does not handle parallel logins correctly.
This is a regression introduced in #3225.
How Has This Been Tested?
n/a
Screenshots / Logs (if applicable)
Checklist:
pnpm buildpnpm i18n:extractSummary by CodeRabbit