Skip to content

ci: fix docker login race condition - #3303

Merged
0xSysR3ll merged 1 commit into
developfrom
ci/fix-docker-race-condition
Jul 29, 2026
Merged

ci: fix docker login race condition#3303
0xSysR3ll merged 1 commit into
developfrom
ci/fix-docker-race-condition

Conversation

@M0NsTeRRR

@M0NsTeRRR M0NsTeRRR commented Jul 29, 2026

Copy link
Copy Markdown
Member

Description

It seems that docker login action does not handle parallel logins correctly.
This is a regression introduced in #3225.

How Has This Been Tested?

n/a

Screenshots / Logs (if applicable)

Checklist:

  • I have read and followed the contribution guidelines.
  • Disclosed any use of AI (see our policy)
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • Successful build pnpm build
  • Translation keys pnpm i18n:extract
  • Database migration (if required)

Summary by CodeRabbit

  • Chores
    • Improved the consistency of container publishing across preview, continuous integration, and release workflows.
    • Registry authentication now occurs in a defined sequence, helping ensure images are published reliably to supported container registries.
    • Existing credentials, registry destinations, and publishing behavior remain unchanged.

Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>
@M0NsTeRRR
M0NsTeRRR requested a review from a team as a code owner July 29, 2026 00:38
@M0NsTeRRR M0NsTeRRR added this to the v3.4.1 milestone Jul 29, 2026
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 67265d34-7e5d-429b-bf1b-a78a0d57f6ec

📥 Commits

Reviewing files that changed from the base of the PR and between 45f7a7a and 1c9ecc1.

📒 Files selected for processing (3)
  • .github/workflows/ci.yml
  • .github/workflows/preview.yml
  • .github/workflows/release.yml

📝 Walkthrough

Walkthrough

Docker Hub and GitHub Container Registry login steps were repositioned in CI, preview, and release workflows to run sequentially rather than inside parallel blocks. Authentication actions, versions, and credential sources remain unchanged.

Changes

Registry authentication flow

Layer / File(s) Summary
Move registry logins after parallel work
.github/workflows/ci.yml, .github/workflows/preview.yml, .github/workflows/release.yml
Docker Hub and GHCR login steps now run sequentially in publish and sign jobs while retaining the existing actions and credentials.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: 0xsysr3ll, gauthier-th, sudo-kraken

Poem

I’m a bunny with badges, hopping in line,
Docker then GHCR, sequentially fine.
The tokens stay secret, the actions stay true,
Parallel blocks now let logins pass through.
Hop hop, the workflow is tidy and new!

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: fixing a Docker login race condition in CI.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seerr-automation-bot seerr-automation-bot modified the milestones: v3.4.1, v3.5.0 Jul 29, 2026
@0xSysR3ll
0xSysR3ll merged commit 95e18de into develop Jul 29, 2026
17 checks passed
@0xSysR3ll
0xSysR3ll deleted the ci/fix-docker-race-condition branch July 29, 2026 07:35
@M0NsTeRRR M0NsTeRRR modified the milestones: v3.5.0, v3.4.1 Jul 30, 2026
gabrielcosi pushed a commit to gabrielcosi/home-ops that referenced this pull request Jul 30, 2026
…1) (#193)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ghcr.io/seerr-team/seerr](https://github.com/seerr-team/seerr) | patch | `v3.4.0` → `v3.4.1` |

---

### Release Notes

<details>
<summary>seerr-team/seerr (ghcr.io/seerr-team/seerr)</summary>

### [`v3.4.1`](https://github.com/seerr-team/seerr/releases/tag/v3.4.1)

[Compare Source](seerr-team/seerr@v3.4.0...v3.4.1)

##### 🐛 Bug Fixes

- *(ui)* Keep user list action buttons sized with a single user ([#&#8203;3311](seerr-team/seerr#3311)) - ([f926248](seerr-team/seerr@f926248))
- Don't delete requests when removing media from arr ([#&#8203;3288](seerr-team/seerr#3288)) - ([3ee6f92](seerr-team/seerr@3ee6f92))
- Handle already-removed media in radarr/sonarr delete ([#&#8203;3209](seerr-team/seerr#3209)) - ([8ea0c17](seerr-team/seerr@8ea0c17))

##### ⚙️ Miscellaneous Tasks

- *(release)* Prepare v3.4.1 - ([69f73a6](seerr-team/seerr@69f73a6))
- *(release)* Prepare v3.4.1 release - ([5c8f1cb](seerr-team/seerr@5c8f1cb))
- Fix docker login race condition ([#&#8203;3303](seerr-team/seerr#3303)) - ([95e18de](seerr-team/seerr@95e18de))
- Parallelize the action steps when possible ([#&#8203;3225](seerr-team/seerr#3225)) - ([45f7a7a](seerr-team/seerr@45f7a7a))

</details>

---

### Configuration

📅 **Schedule**: (in timezone Europe/Berlin)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4wLjAiLCJ1cGRhdGVkSW5WZXIiOiI0NC4wLjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbInJlbm92YXRlL2NvbnRhaW5lciIsInR5cGUvcGF0Y2giXX0=-->

Reviewed-on: https://git.xcd.dev/gabrielcosi/home-ops/pulls/193
doonga pushed a commit to greyrock-labs/home-ops that referenced this pull request Jul 30, 2026
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [seerr/seerr](https://github.com/seerr-team/seerr) | patch | `v3.4.0` → `v3.4.1` |

---

### Release Notes

<details>
<summary>seerr-team/seerr (seerr/seerr)</summary>

### [`v3.4.1`](https://github.com/seerr-team/seerr/releases/tag/v3.4.1)

[Compare Source](seerr-team/seerr@v3.4.0...v3.4.1)

##### 🐛 Bug Fixes

- *(ui)* Keep user list action buttons sized with a single user ([#&#8203;3311](seerr-team/seerr#3311)) - ([f926248](seerr-team/seerr@f926248))
- Don't delete requests when removing media from arr ([#&#8203;3288](seerr-team/seerr#3288)) - ([3ee6f92](seerr-team/seerr@3ee6f92))
- Handle already-removed media in radarr/sonarr delete ([#&#8203;3209](seerr-team/seerr#3209)) - ([8ea0c17](seerr-team/seerr@8ea0c17))

##### ⚙️ Miscellaneous Tasks

- *(release)* Prepare v3.4.1 - ([69f73a6](seerr-team/seerr@69f73a6))
- *(release)* Prepare v3.4.1 release - ([5c8f1cb](seerr-team/seerr@5c8f1cb))
- Fix docker login race condition ([#&#8203;3303](seerr-team/seerr#3303)) - ([95e18de](seerr-team/seerr@95e18de))
- Parallelize the action steps when possible ([#&#8203;3225](seerr-team/seerr#3225)) - ([45f7a7a](seerr-team/seerr@45f7a7a))

</details>

---

### Configuration

📅 **Schedule**: (in timezone America/New_York)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4wLjAiLCJ1cGRhdGVkSW5WZXIiOiI0NC4wLjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbInJlbm92YXRlL2NvbnRhaW5lciIsInR5cGUvcGF0Y2giXX0=-->

Reviewed-on: https://git.greyrock.io/greyrock-labs/home-ops/pulls/213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants