Skip to content
This repository was archived by the owner on Apr 24, 2024. It is now read-only.

LAPP-59 wrapping flush with try-catch#128

Merged
lubird merged 5 commits intosegmentio:masterfrom
cgalan-applaudo:feature/LAPP-59
May 21, 2020
Merged

LAPP-59 wrapping flush with try-catch#128
lubird merged 5 commits intosegmentio:masterfrom
cgalan-applaudo:feature/LAPP-59

Conversation

@cgalan-applaudo
Copy link
Copy Markdown
Contributor

This will prevent any crash of the customer app caused by an unhandled exception

@codecov-io
Copy link
Copy Markdown

codecov-io commented May 6, 2020

Codecov Report

Merging #128 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
+ Coverage   86.84%   86.91%   +0.06%     
==========================================
  Files          26       26              
  Lines         768      772       +4     
  Branches       79       79              
==========================================
+ Hits          667      671       +4     
  Misses        100      100              
  Partials        1        1              
Impacted Files Coverage Δ
Analytics/Flush/AsyncIntervalFlushHandler.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a4aec4...56c8977. Read the comment docs.

@lubird lubird merged commit c84ddb3 into segmentio:master May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants