LAPP-59 wrapping flush with try-catch

Analytics/Flush/AsyncIntervalFlushHandler.cs

@@ -70,6 +70,10 @@ private async Task PerformFlush()
             {
                 await FlushImpl();
             }
+            catch
+            {
+                Logger.Error("Flush couldn't be completed");
+            }
             finally
             {
                 _semaphore.Release();

Test.Net35/Flush/AsyncIntervalFlushHandlerTests.cs

@@ -183,6 +183,18 @@ public void IntervalFlushTriggerTwoConcurrentProcesses()
             _mockRequestHandler.Verify(r => r.MakeRequest(It.IsAny<Batch>()), times: Times.Exactly(2));
         }
 
+        [Test]
+        public void FlushCatchExceptions()
+        {
+            _mockRequestHandler.Setup(r => r.MakeRequest(It.IsAny<Batch>())).Throws<System.Exception>();
+
+            _ = _handler.Process(new Track(null, null, null, null));
+
+            _handler.Flush();
+
+            _mockRequestHandler.Verify(r => r.MakeRequest(It.IsAny<Batch>()), times: Times.Exactly(1));
+        }
+
         [Test]
         public void IntervalFlushSendsBatchesThatAreSmallerThan512Kb()
         {

Test.Net35/Stats/StatisticsTests.cs

@@ -1,7 +1,7 @@
 using NUnit.Framework;
 using Segment.Stats;
 
-namespace Segment.Net35.Stats
+namespace Segment.Test.Stats
 {
     [TestFixture]
     public class StatisticsTests

Test.Net45/Flush/AsyncIntervalFlushHandlerTests.cs

@@ -241,6 +241,18 @@ public async Task IntervalFlushSendsBatchesThatAreSmallerThan512Kb()
 
         }
 
+        [Test]
+        public void FlushCatchExceptions()
+        {
+            _mockRequestHandler.Setup(r => r.MakeRequest(It.IsAny<Batch>())).Throws<System.Exception>();
+
+            _ = _handler.Process(new Track(null, null, null, null));
+
+            _handler.Flush();
+
+            _mockRequestHandler.Verify(r => r.MakeRequest(It.IsAny<Batch>()), times: Times.Exactly(1));
+        }
+
         [Test]
         public async Task BatchMeetTheMaxNumberOfActions()
         {

Test.NetStandard20/Flush/AsyncIntervalFlushHandlerTests.cs

@@ -241,6 +241,18 @@ public async Task IntervalFlushSendsBatchesThatAreSmallerThan512Kb()
 
         }
 
+        [Test]
+        public void FlushCatchExceptions()
+        {
+            _mockRequestHandler.Setup(r => r.MakeRequest(It.IsAny<Batch>())).Throws<System.Exception>();
+
+            _ = _handler.Process(new Track(null, null, null, null));
+
+            _handler.Flush();
+
+            _mockRequestHandler.Verify(r => r.MakeRequest(It.IsAny<Batch>()), times: Times.Exactly(1));
+        }
+
         [Test]
         public async Task BatchMeetTheMaxNumberOfActions()
         {

Test/Flush/AsyncIntervalFlushHandlerTests.cs

@@ -237,6 +237,18 @@ public async Task BatchMeetTheMaxNumberOfActions()
             _mockRequestHandler.Verify(r => r.MakeRequest(It.Is<Batch>(b => b.batch.Count == 5)), Times.Exactly(1));
         }
 
+        [Test]
+        public void FlushCatchExceptions()
+        {
+            _mockRequestHandler.Setup(r => r.MakeRequest(It.IsAny<Batch>())).Throws<System.Exception>();
+
+            _ = _handler.Process(new Track(null, null, null, null));
+
+            _handler.Flush();
+
+            _mockRequestHandler.Verify(r => r.MakeRequest(It.IsAny<Batch>()), times: Times.Exactly(1));
+        }
+
         private string GetEventName(int size)
         {
             return string.Join("", Enumerable.Range(0, size).Select(_ => "a"));