This repository was archived by the owner on Sep 3, 2022. It is now read-only.
perf(uuid): use only v4 needed from uuid #126
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
midudev
requested review from
fathyb and
jlee9595
and removed request for
jlee9595
fathyb
suggested changes
Feb 4, 2020
package.json
Outdated
| "segmentio-facade": "^3.0.2", | ||
| "spark-md5": "^2.0.2", | ||
| "uuid": "^2.0.2" | ||
| "uuid": "3.4.0" |
Contributor
There was a problem hiding this comment.
Could you change the range to use a caret? yarn upgrade uuid@^3.4.0
This will prevent useless duplications of uuid when ajs in included in bigger projects.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
analytics.jslibrary is bundling a LOT of code and impacting negatively performance to our sites of Adevinta. We would like to ship less JS code, specially when not needed.This PR upgrade uuid to latest version in order to be able to load only the needed piece of code needed. We would like to start working on more changes like this to keep reducing the size of the library.
Is backwards compatible? Yes