Skip to content
This repository was archived by the owner on Sep 3, 2022. It is now read-only.

Conversation

@dk1027
Copy link
Contributor

@dk1027 dk1027 commented Feb 24, 2020

Consolidating the changes from these PRs:
#127
#126

Jira ticket
https://segment.atlassian.net/browse/LIB-1595

Tests
Automated tests passing; released and tested on staging

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@61ff1a2). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #132   +/-   ##
=========================================
  Coverage          ?   97.75%           
=========================================
  Files             ?       12           
  Lines             ?      756           
  Branches          ?        0           
=========================================
  Hits              ?      739           
  Misses            ?       17           
  Partials          ?        0
Impacted Files Coverage Δ
lib/cookie.js 94.73% <100%> (ø)
lib/normalize.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61ff1a2...6e9caa3. Read the comment docs.

@ndhoule
Copy link
Contributor

ndhoule commented Feb 25, 2020

Codecov Report

Merging #132 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
- Coverage   97.75%   97.75%   -0.01%     
==========================================
  Files          12       12              
  Lines         758      756       -2     
==========================================
- Hits          741      739       -2     
  Misses         17       17              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61ff1a2...5520112. Read the comment docs.

@dk1027 dk1027 changed the title Removed unnecessary packages LIB-1591: Removed unnecessary packages Feb 25, 2020
@dk1027 dk1027 merged commit bf06f41 into master Feb 25, 2020
@dk1027 dk1027 deleted the dk1027/lib-1595 branch February 25, 2020 23:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants