AJS-Next: fix destinations with wrong aliases #566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nettofarah
commented
Mar 3, 2021
|
|
||
| /* eslint-disable */ | ||
| window.$zopim||(function(d,s){var z=$zopim=function(c){z._.push(c)},$=z.s=d.createElement(s),e=d.getElementsByTagName(s)[0];z.set=function(o){z.set._.push(o)};z._=[];z.set._=[];$.async=!0;$.setAttribute('charset','utf-8');$.src=scriptUrl;z.t=+new Date;$.type='text/javascript';e.parentNode.insertBefore($,e)})(document,'script'); | ||
| window.$zopim || (function(d, s) { var z = (window.$zopim = function(c) { z._.push(c); }), $ = (z.s = d.createElement(s)), e = d.getElementsByTagName(s)[0]; z.set = function(o) { z.set._.push(o); }; z._ = []; z.set._ = []; $.async = !0; $.setAttribute('charset', 'utf-8'); $.src = scriptUrl; z.t = +new Date(); $.type = 'text/javascript'; e.parentNode.insertBefore($, e); })(document, 'script'); |
Contributor
Author
There was a problem hiding this comment.
the compiled code for zopim would break because of a bad assignment.
The only real change here is $zopim= to window.$zompim=
nettofarah
commented
Mar 3, 2021
| `.trim(); | ||
|
|
||
| const filename = file.replace('.js', '.dynamic.js'); | ||
| const filename = file.replace(/\.js$/, '.dynamic.js'); |
Contributor
Author
There was a problem hiding this comment.
This makes compilation/uploads more reliable in dev
pooyaj
approved these changes
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change a few destinations to have the package name match the destination creation name, so ajs next is able to load the correct destination dynamically from S3.
Are there breaking changes in this PR?
N/A
Testing
Testing completed successfully using ajs-next in staging using this website: https://repl.it/@nettofarah/ajs-next-broken-integrations-qa#index.html