Skip to content

AJS-Next: fix destinations with wrong aliases #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nettofarah merged 9 commits into from
Mar 3, 2021
Merged

AJS-Next: fix destinations with wrong aliases #566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e99bfd8
Alias tv-squaredl
nettofarah Mar 3, 2021
ec8617c
Fix replace regex
nettofarah Mar 3, 2021
ce65295
Name tv-squared properly
nettofarah Mar 3, 2021
a530e08
Name hello-bar properly
nettofarah Mar 3, 2021
b28af57
Properly name track-js
nettofarah Mar 3, 2021
0bfae12
Update zopim
nettofarah Mar 3, 2021
c57f1af
Bump zopim
nettofarah Mar 3, 2021
b01fd0e
Update broken survicate dep
nettofarah Mar 3, 2021
edccb35
Revert "Update broken survicate dep"
nettofarah Mar 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 integrations/hellobar/HISTORY.md → integrations/hello-bar/HISTORY.md
View file
Open in desktop
File renamed without changes.
0 integrations/hellobar/README.md → integrations/hello-bar/README.md
View file
Open in desktop
File renamed without changes.
0 integrations/hellobar/karma.conf-ci.js → integrations/hello-bar/karma.conf-ci.js
View file
Open in desktop
File renamed without changes.
0 integrations/hellobar/karma.conf.js → integrations/hello-bar/karma.conf.js
View file
Open in desktop
File renamed without changes.
0 integrations/hellobar/lib/index.js → integrations/hello-bar/lib/index.js
View file
Open in desktop
File renamed without changes.
0 integrations/hellobar/package.json → integrations/hello-bar/package.json
View file
Open in desktop
File renamed without changes.
0 integrations/hellobar/test/index.test.js → integrations/hello-bar/test/index.test.js
View file
Open in desktop
File renamed without changes.
0 integrations/trackjs/HISTORY.md → integrations/track-js/HISTORY.md
View file
Open in desktop
File renamed without changes.
0 integrations/trackjs/README.md → integrations/track-js/README.md
View file
Open in desktop
File renamed without changes.
0 integrations/trackjs/karma.conf-ci.js → integrations/track-js/karma.conf-ci.js
View file
Open in desktop
File renamed without changes.
0 integrations/trackjs/karma.conf.js → integrations/track-js/karma.conf.js
View file
Open in desktop
File renamed without changes.
0 integrations/trackjs/lib/index.js → integrations/track-js/lib/index.js
View file
Open in desktop
File renamed without changes.
0 integrations/trackjs/package.json → integrations/track-js/package.json
View file
Open in desktop
File renamed without changes.
0 integrations/trackjs/test/index.test.js → integrations/track-js/test/index.test.js
View file
Open in desktop
File renamed without changes.
0 integrations/tvsquared/HISTORY.md → integrations/tv-squared/HISTORY.md
View file
Open in desktop
File renamed without changes.
0 integrations/tvsquared/README.md → integrations/tv-squared/README.md
View file
Open in desktop
File renamed without changes.
0 integrations/tvsquared/karma.conf-ci.js → integrations/tv-squared/karma.conf-ci.js
View file
Open in desktop
File renamed without changes.
0 integrations/tvsquared/karma.conf.js → integrations/tv-squared/karma.conf.js
View file
Open in desktop
File renamed without changes.
0 integrations/tvsquared/lib/index.js → integrations/tv-squared/lib/index.js
View file
Open in desktop
File renamed without changes.
0 integrations/tvsquared/package.json → integrations/tv-squared/package.json
View file
Open in desktop
File renamed without changes.
0 integrations/tvsquared/test/index.test.js → integrations/tv-squared/test/index.test.js
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion integrations/zopim/lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ Zopim.prototype.load = function(done) {
var scriptUrl = fmt('//v2.zopim.com/?%s', zopimId);

/* eslint-disable */
window.$zopim||(function(d,s){var z=$zopim=function(c){z._.push(c)},$=z.s=d.createElement(s),e=d.getElementsByTagName(s)[0];z.set=function(o){z.set._.push(o)};z._=[];z.set._=[];$.async=!0;$.setAttribute('charset','utf-8');$.src=scriptUrl;z.t=+new Date;$.type='text/javascript';e.parentNode.insertBefore($,e)})(document,'script');
window.$zopim || (function(d, s) { var z = (window.$zopim = function(c) { z._.push(c); }), $ = (z.s = d.createElement(s)), e = d.getElementsByTagName(s)[0]; z.set = function(o) { z.set._.push(o); }; z._ = []; z.set._ = []; $.async = !0; $.setAttribute('charset', 'utf-8'); $.src = scriptUrl; z.t = +new Date(); $.type = 'text/javascript'; e.parentNode.insertBefore($, e); })(document, 'script');
Copy link
Contributor Author

@nettofarah nettofarah Mar 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the compiled code for zopim would break because of a bad assignment.
The only real change here is $zopim= to window.$zompim=

/* eslint-enable */

when(this.loaded, done);
Expand Down
2 changes: 1 addition & 1 deletion integrations/zopim/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@segment/analytics.js-integration-zopim",
"description": "The Zopim analytics.js integration.",
"version": "2.0.0",
"version": "2.0.1",
"keywords": [
"analytics.js",
"analytics.js-integration",
Expand Down
2 changes: 1 addition & 1 deletion scripts/build-shells.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ window['${libraryName}Loader'] = function() {
}
`.trim();

const filename = file.replace('.js', '.dynamic.js');
const filename = file.replace(/\.js$/, '.dynamic.js');
Copy link
Contributor Author

@nettofarah nettofarah Mar 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes compilation/uploads more reliable in dev

fs.writeFileSync(filename + '.gz', zlib.gzipSync(dynamic));
fs.writeFileSync(filename, dynamic);
});