Types failing in `4.14.2`

[fzembow]

Hi!

I updated from 4.13.1 to 4.14.2, and now when we run tsc --noEmit, the following error is displayed

./node_modules/@segment/snippet/types.d.ts:12:13 - error TS2411: Property 'All' of type 'boolean | undefined' is not assignable to string index type 'boolean'.

12             All?: boolean
               ~~~

We are using typescript 3.8.3 .. a bit dated, but perhaps there is a mistake in this type definition?

[lizraeli]

Looks like the error is happening in typescript 4.3.5 too, depending on if strictNullChecks is enabled - link to playground

[lizraeli]

This error is happening with strict type checks in the following interface:

    interface LoadOptions {
        integrations?: {
            All?: boolean
            [key: string]: boolean
        }
    }

The problem with the All property being optional, is that this allows passing undefined as the value, while the indexed type [key: string]: boolean defines all properties as being boolean. One option is to remove the All property from the definition, since it's already included in [key: string]: boolean.

[fzembow]

Gonna close for now, doesn't seem critical

[fzembow]

Whoops, meant to close our internal ticket regarding this. You should definitely still fix :)

[aslilac]

It's laughable that you want someone to fix this for free when y'all are paid for a service