default SSTORE value back to original 20k#2758
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2758 +/- ##
==========================================
- Coverage 57.04% 57.02% -0.02%
==========================================
Files 2004 2004
Lines 164603 164603
==========================================
- Hits 93897 93869 -28
- Misses 62507 62533 +26
- Partials 8199 8201 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
yzang2019
approved these changes
Jan 26, 2026
stevenlanders
approved these changes
Jan 26, 2026
masih
reviewed
Jan 26, 2026
Collaborator
masih
left a comment
masih
left a comment
There was a problem hiding this comment.
I still see a bunch of 72000s across tests. @jewei1997 would you mind doing a search for it as a sanity check please?
| ret, g, err := p.RunAndCalculateGas(evm, caller, caller, append(p.GetExecutor().(*pointer.PrecompileExecutor).AddNativePointerID, args...), suppliedGas, nil, nil, false, false) | ||
| require.Nil(t, err) | ||
| require.Equal(t, uint64(8679314), g) | ||
| require.Equal(t, uint64(8887314), g) |
Collaborator
There was a problem hiding this comment.
Sanity checking that this is supposed to become 208K less?
philipsu522
approved these changes
Jan 26, 2026
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release/v6.3
git worktree add -d .worktree/backport-2758-to-release/v6.3 origin/release/v6.3
cd .worktree/backport-2758-to-release/v6.3
git switch --create backport-2758-to-release/v6.3
git cherry-pick -x 77cc04ed9137b6994735dcb934f17321bbcb9f83 |
jewei1997
added a commit
that referenced
this pull request
Jan 26, 2026
## Describe your changes and provide context backport of this PR #2758 ## Testing performed to validate your change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
change SSTORE chain param value back to original 20k. We may change this in the future with a gov proposal.
Testing performed to validate your change
existing tests