default SSTORE value back to original 20k#2759
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (38.19%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## release/v6.3 #2759 +/- ##
=============================================
Coverage 43.34% 43.34%
=============================================
Files 1866 1866
Lines 155279 155279
=============================================
+ Hits 67301 67312 +11
+ Misses 81962 81954 -8
+ Partials 6016 6013 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| ret, g, err := p.RunAndCalculateGas(evm, caller, caller, append(p.GetExecutor().(*pointer.PrecompileExecutor).AddNativePointerID, args...), suppliedGas, nil, nil, false, false) | ||
| require.Nil(t, err) | ||
| require.Equal(t, uint64(8679314), g) | ||
| require.Equal(t, uint64(8887314), g) |
There was a problem hiding this comment.
thinking - why would this be higher ?
There was a problem hiding this comment.
i dont think this is gas used. I think it's gas remaining, so the remaining gas is higher, which means it consumed less gas.
This reverts commit a672081.
5 participants
Describe your changes and provide context
backport of this PR #2758
Testing performed to validate your change