Skip to content

[giga] clear up cache after Write#2827

Merged
codchen merged 1 commit intomainfrom
tony/clear-up-cache
Feb 24, 2026
Merged

[giga] clear up cache after Write#2827
codchen merged 1 commit intomainfrom
tony/clear-up-cache

Conversation

@codchen
Copy link
Collaborator

@codchen codchen commented Feb 10, 2026

Describe your changes and provide context

The logic to preserve cache entries was added to circumvent the visibility issue with base store. This PR removes it because:

  1. it's no longer needed as add original cachekv as base layer #2780 has addressed the visibility issue
  2. it causes stale cache reads if some balance is modified in giga, the tx falls back, and v2 modifies the balance to a different value, then subsequent txs will see incorrect balance when processed in giga

Testing performed to validate your change

@github-actions
Copy link

github-actions bot commented Feb 10, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedFeb 24, 2026, 3:27 AM

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 56.19%. Comparing base (76f70dd) to head (742d06c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
giga/deps/store/cachekv.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2827       +/-   ##
===========================================
- Coverage   58.14%   56.19%    -1.95%     
===========================================
  Files        2106        7     -2099     
  Lines      173294      557   -172737     
===========================================
- Hits       100756      313   -100443     
+ Misses      63596      214    -63382     
+ Partials     8942       30     -8912     
Flag Coverage Δ
sei-chain 0.00% <0.00%> (-58.12%) ⬇️
sei-db 68.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
giga/deps/store/cachekv.go 0.00% <0.00%> (-57.45%) ⬇️

... and 2100 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codchen codchen force-pushed the tony/clear-up-cache branch from 7066b55 to 742d06c Compare February 24, 2026 03:26
@codchen codchen merged commit 1eb6794 into main Feb 24, 2026
35 checks passed
@codchen codchen deleted the tony/clear-up-cache branch February 24, 2026 03:48
yzang2019 added a commit that referenced this pull request Feb 24, 2026
* main:
  go bench read + write receipts/logs for parquet vs pebble (#2794)
  [giga] clear up cache after Write (#2827)
yzang2019 added a commit that referenced this pull request Feb 27, 2026
* main: (66 commits)
  feat(flatkv): include legacyDB in ApplyChangeSets, LtHash, and read path (#2978)
  Deflake mempool tests with Eventually-based block waits (#2983)
  Demote noisy gasless classification log to debug level (#2982)
  Harden `TestStateLock_NoPOL` against proposal/timeout race (#2980)
  added a config parameter to limit outbound p2p connections. (#2974)
  merged unconditional and persistent peers status (#2977)
  Fix race between file pruning and in-flight parquet queries (#2975)
  fix(giga): don't migrate balance on failed txs (#2961)
  Fix hanging upgrade tests by adding timeouts to wait_for_height (#2976)
  Add snapshot import for Giga Live State (#2970)
  Fix Rocksdb MVCC read timestamp lifetime for iterators (#2971)
  Reduce exposed tendermint RPC endpoint (#2968)
  Deflake `TestStateLock_NoPOL` by widening propose timeout in test (#2969)
  go bench read + write receipts/logs for parquet vs pebble (#2794)
  [giga] clear up cache after Write (#2827)
  fix: use correct EVM storage key prefix in benchmark key generation (#2966)
  Harden staking precompile test against CI flakiness (#2967)
  Don't sync flatKV DBs when committing  (#2964)
  Fix flaky `TestStateLock_POLSafety1` (#2962)
  Add metrics for historical proof success/failure rate (#2958)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants