Add metrics for historical proof success/failure rate#2958
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2958 +/- ##
===========================================
- Coverage 58.15% 56.29% -1.87%
===========================================
Files 2106 6 -2100
Lines 173285 1009 -172276
===========================================
- Hits 100777 568 -100209
+ Misses 63561 378 -63183
+ Partials 8947 63 -8884
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Kbhat1
reviewed
Feb 23, 2026
| } | ||
|
|
||
| // Must have proof ops from underlying store query before appending commit proof. | ||
| if res.ProofOps == nil { |
Contributor
There was a problem hiding this comment.
Was removing this intentional? We check res.ProofOps.Ops right after this before checking res.ProofOps is not nil
Contributor
Author
There was a problem hiding this comment.
We didn't remove this, just combining it with the other if to remove duplicate code
Contributor
There was a problem hiding this comment.
But we check res.ProofOps.Ops right after this before checking res.ProofOps is not nil
Kbhat1
approved these changes
Feb 23, 2026
masih
requested changes
Feb 23, 2026
Collaborator
masih
left a comment
masih
left a comment
There was a problem hiding this comment.
Couple of issues to fix first.
Thank you for adding this metric; super useful 🙌
masih
reviewed
Feb 23, 2026
masih
approved these changes
Feb 23, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Feb 23, 2026
## Describe your changes and provide context Add metrics to indicate historical proof success/failure rate due to rate limiting. ## Testing performed to validate your change (cherry picked from commit 9e7161b)
|
Successfully created backport PR for |
yzang2019
added a commit
that referenced
this pull request
Feb 27, 2026
* main: (66 commits) feat(flatkv): include legacyDB in ApplyChangeSets, LtHash, and read path (#2978) Deflake mempool tests with Eventually-based block waits (#2983) Demote noisy gasless classification log to debug level (#2982) Harden `TestStateLock_NoPOL` against proposal/timeout race (#2980) added a config parameter to limit outbound p2p connections. (#2974) merged unconditional and persistent peers status (#2977) Fix race between file pruning and in-flight parquet queries (#2975) fix(giga): don't migrate balance on failed txs (#2961) Fix hanging upgrade tests by adding timeouts to wait_for_height (#2976) Add snapshot import for Giga Live State (#2970) Fix Rocksdb MVCC read timestamp lifetime for iterators (#2971) Reduce exposed tendermint RPC endpoint (#2968) Deflake `TestStateLock_NoPOL` by widening propose timeout in test (#2969) go bench read + write receipts/logs for parquet vs pebble (#2794) [giga] clear up cache after Write (#2827) fix: use correct EVM storage key prefix in benchmark key generation (#2966) Harden staking precompile test against CI flakiness (#2967) Don't sync flatKV DBs when committing (#2964) Fix flaky `TestStateLock_POLSafety1` (#2962) Add metrics for historical proof success/failure rate (#2958) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Add metrics to indicate historical proof success/failure rate due to rate limiting.
Testing performed to validate your change