Unify EVM SS into single DB with store key prefixes#3134
Merged
Conversation
Replace 5 separate MVCC databases (nonce, codehash, code, storage, legacy) with a single DB. EVM sub-types are namespaced via the MVCC store key prefix (s/k:<storeType>/) instead of separate directories. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Kbhat1
changed the title
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3134 +/- ##
=======================================
Coverage 58.79% 58.80%
=======================================
Files 2054 2054
Lines 168315 168375 +60
=======================================
+ Hits 98958 99009 +51
- Misses 60610 60614 +4
- Partials 8747 8752 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Kbhat1
changed the title
Keep the current unified layout as the default while allowing EVM data to be split across physical DBs. Preserve the existing evm keyspace and metadata layout even when separated so the change only affects placement, not encoding. Made-with: Cursor
blindchaser
reviewed
Apr 7, 2026
| } | ||
| } | ||
| }() | ||
| return db.Import(version, filtered) |
Contributor
There was a problem hiding this comment.
if db.Import(version, filtered) returns early with an error, the filtering goroutine at line 275 blocks forever on filtered <- node (nobody drains filtered anymore). this also prevents draining the upstream ch, which causes the composite store's sendNode(evmCh, ...) to block
blindchaser
reviewed
Apr 7, 2026
| if len(evmChangesets) == 0 { | ||
| return nil | ||
| } | ||
| return db.ApplyChangesetAsync(version, evmChangesets) |
Contributor
There was a problem hiding this comment.
ApplyChangesetSync and ApplyChangesetAsync shares most of the code, how about extract shared func like applyChangeset()
blindchaser
approved these changes
Apr 7, 2026
yzang2019
approved these changes
Apr 7, 2026
Resolve the EVM SS merge conflicts while preserving the branch's unified/full-key storage behavior and bringing in mainline updates. Made-with: Cursor
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-3134-to-release/v6.4
git worktree add --checkout .worktree/backport-3134-to-release/v6.4 backport-3134-to-release/v6.4
cd .worktree/backport-3134-to-release/v6.4
git reset --hard HEAD^
git cherry-pick -x 36f9664790cf86a33a287670e8939d466a8c339f
git push --force-with-lease |
Kbhat1
added a commit
that referenced
this pull request
Apr 8, 2026
- Consolidate EVM state-store sub-DBs into a single DB by default while preserving the existing evm keyspace and MVCC key encoding - Add configuration to optionally split EVM data back across per-type physical DBs without changing logical read/write behavior. - Unit tests - Verifying w/ state sync on node --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> (cherry picked from commit 36f9664)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Testing performed to validate your change