refactor(task): drop taskParamser interface; use client.TaskBuilder directly

[bdchatham]

Resolves #161.

Summary

Removes the controller-local taskParamser interface (toRequestParams(), taskType()) and the 14 *Params shells that implemented it. The executor now constrains T to sidecar.TaskBuilder (the seictl-defined interface), so wire format, validation, and task-type strings all flow from a single source of truth in seictl.

20 files, -284 net lines, 2 files deleted.

What changed

Executor (internal/task/sidecar.go)

• sidecarExecution[T] constraint changes from T any to T sidecar.TaskBuilder
• Submit path: build wire request via e.params.ToTaskRequest(), then override req.Id with the deterministic plan-task UUID. Override happens at the TaskRequest boundary, not on the wrapper's TaskMeta — keeps the executor decoupled from wrapper internals (Demeter)
• Old taskParamser interface + 14-entry assertion list deleted

Registry (internal/task/task.go)

• All 14 sidecar registry entries swap from sidecarTask[*Params] to sidecarTask[sidecar.*Task]
• One exception (config-apply): sidecarTask[configApplyTask] — the unexported local type below
• Generic constraints (sidecarTask, deserializeSidecar) change to T sidecar.TaskBuilder

The one local exception: configApplyTask

Seictl's client.ConfigApplyTask wraps inputs in seiconfig.ConfigIntent rather than flat fields. Direct swap would change Params.Raw from {"mode": "X", ...} to {"Intent": {"mode": "X", ...}} — operationally fine but breaks structural compat for in-flight plans on rollover.

Solution: 14-line unexported type in internal/task/config.go that anonymously embeds seiconfig.ConfigIntent (whose existing json:"mode"/json:"overrides,omitempty"/etc. tags match today's controller shape exactly) and delegates the three TaskBuilder methods to a constructed client.ConfigApplyTask. Storage shape stable; validation and wire format still single-sourced upstream.

Planner (internal/planner/*.go)

• 6 sites that constructed *task.ConfigApplyParams now construct *seiconfig.ConfigIntent (cleaner — same data, fewer copies)
• All other planner construction sites use sidecar.*Task directly
• paramsForTaskType factory updated; snapshotRestoreParams/discoverPeersParams/configureStateSyncParams renamed to *Task and return seictl wrappers

Tests (~10 sites)

Mechanical type-name swaps where tests unmarshal Params.Raw into typed structs. No behavior assertions changed.

Dependencies

• go.mod: seictl v0.0.44 → v0.0.45 (picks up SetGenesisPeersTask from seictl#150)

Storage shape impact (operator-visible only)

PlannedTask.Params.Raw shape shifts from controller-side flat camelCase to seictl-side Go-PascalCase for 13 of 14 task types. Cosmetic change for operators running kubectl get snd -o yaml; no programmatic consumer cares — the field is internal to the controller and the wire payload to seictl is built fresh from ToTaskRequest() at submit time. Cross-review confirmed zero Params.Raw consumers in either repo outside the controller's own reconcile loop.

ConfigApply preserves shape via the embedding pattern.

Mid-rollover safety

In-flight plans persisted under v0.0.44 have Params.Raw bytes in the old camelCase shape. New controller deserializes them via Go's case-insensitive json unmarshal into the seictl client.*Task types — works cleanly for all 13 simple tasks (no acronym mismatches). ConfigApply round-trips byte-identically because the embedding pattern preserves the flat shape.

Verification

• GOWORK=off go build ./... — clean
• GOWORK=off go test ./... — all packages pass
• GOWORK=off go vet ./... — clean
• golangci-lint run — 0 issues
• grep -rn 'taskParamser\|toRequestParams' — zero residual refs

References

• chore(client): drop ExportState orphan; add SetGenesisPeersTask helper seictl#150 — added SetGenesisPeersTask typed wrapper (the last missing piece)
• chore: bump version to v0.0.45 seictl#152 — bumped seictl to v0.0.45 with that wrapper available

🤖 Generated with Claude Code