Merged
Conversation
Picks up seictl#156 — adds json tags to client.PeerSource. Effect on this repo: PlannedTask.Params.Raw bytes for discover-peers tasks shift from PascalCase (Type/Region/Tags/...) back to camelCase (type/region/tags/...) and drop the omitempty fields, matching the shape operators saw pre-#192. No code changes — controller never references PeerSource fields by struct-tag-sensitive json paths. Mid-rollover safe: pre-existing PascalCase bytes deserialize cleanly into the now-tagged struct via Go's case-insensitive json unmarshal. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Picks up seictl#156 — adds json tags to
client.PeerSource.v0.0.46 → v0.0.47Effect on this repo
PlannedTask.Params.Rawbytes fordiscover-peerstasks shift from PascalCase (Type/Region/Tags/Addresses/Endpoints) back to camelCase (type/region/tags/...) and drop omitempty-eligible fields. Restores the shape operators saw pre-#192.No code changes
Controller never references
PeerSourcefields by struct-tag-sensitive json paths. Tests unmarshal into typed structs which work case-insensitively.Mid-rollover safety
Pre-existing PascalCase
Params.Rawbytes deserialize cleanly into the now-tagged struct via Go's case-insensitive json unmarshal — when no exact tag match is found,encoding/jsonfalls back to case-insensitive comparison against the tag.Verification
GOWORK=off go get github.com/sei-protocol/seictl@v0.0.47— clean 3-line diffGOWORK=off go build ./...— cleanGOWORK=off go test ./...— all packages pass🤖 Generated with Claude Code