Fix build error #2097#2098
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2098 +/- ##
==========================================
- Coverage 84.00% 83.94% -0.07%
==========================================
Files 316 316
Lines 56979 57020 +41
Branches 12084 11838 -246
==========================================
- Hits 47868 47864 -4
- Misses 7905 7963 +58
+ Partials 1206 1193 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
@KangLin please see this formatting error: This: uint8_t buffArray[6] = {0};Should be changed to this: uint8_t buffArray[6] = { 0 };Same for this: uint8_t value[6] = {0};Should be changed to this: uint8_t value[6] = { 0 }; |
Contributor
Author
|
LGTM |
Owner
|
Thank you @KangLin for working on this fix, much appreciated! ❤️ 🙏 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug description
Describe the bug
/home/RabbitRemoteControl/build_linux/source/PcapPlusPlus/Common++/src/OUILookup.cpp: In member function ‘std::string pcpp::/home/RabbitRemoteControl/build_linux/source/PcapPlusPlus/Common++/src/OUILookup.cpp:100:105: error: ‘buffArray’ may be usedgmake[2]: *** [Common++/CMakeFiles/Common++.dir/build.make:163：Common++/CMakeFiles/Common++.dir/src/OUILookup.cpp.o] 错误 1
Detected OS: Linux
Distribution: deepin
Version: 23.1
Architecture: x86_64
gcc (Deepin 12.3.0-17deepin12) 12.3.0
PcapPlusPlus versions tested on
v25.05
Other PcapPlusPlus version (if applicable)
No response
Operating systems tested on
Linux
Other operation systems (if applicable)
deepin 23.1
Compiler version
gcc (Deepin 12.3.0-17deepin12) 12.3.0
Packet capture backend (if applicable)
No response