Skip to content

Fix error for alter column default value CURRENT_TIMESTAMP - #293

Merged
w41ter merged 3 commits into
selectdb:devfrom
wyxxxcat:ts
Dec 16, 2024
Merged

Fix error for alter column default value CURRENT_TIMESTAMP#293
w41ter merged 3 commits into
selectdb:devfrom
wyxxxcat:ts

Conversation

@wyxxxcat

@wyxxxcat wyxxxcat commented Dec 4, 2024

Copy link
Copy Markdown
Contributor
[2024-12-04 18:19:15.863]  WARN job sync failed, job: test, err: [normal] Error 1105 (HY000): errCode = 2, detailMessage = date literal [CURRENT_] is invalid: Unknown time-zone ID: TIMESTAMP
exec sql ALTER TABLE `t` ADD COLUMN `compute_time` datetimev2(0) NULL DEFAULT "CURRENT_TIMESTAMP" COMMENT "计算时间" AFTER `pick_order_big_num` failed
github.com/selectdb/ccr_syncer/pkg/ccr/base.(*Spec).DbExec
    /home/wyxxxcat/ccr-syncer/pkg/ccr/base/spec.go:1166
github.com/selectdb/ccr_syncer/pkg/ccr/base.(*Spec).LightningSchemaChange
    /home/wyxxxcat/ccr-syncer/pkg/ccr/base/spec.go:1245
github.com/selectdb/ccr_syncer/pkg/ccr.(*Job).handleLightningSchemaChange
    /home/wyxxxcat/ccr-syncer/pkg/ccr/job.go:2102
github.com/selectdb/ccr_syncer/pkg/ccr.(*Job).handleBinlog
    /home/wyxxxcat/ccr-syncer/pkg/ccr/job.go:2720
github.com/selectdb/ccr_syncer/pkg/ccr.(*Job).handleBinlogs
    /home/wyxxxcat/ccr-syncer/pkg/ccr/job.go:2657
github.com/selectdb/ccr_syncer/pkg/ccr.(*Job).incrementalSync
    /home/wyxxxcat/ccr-syncer/pkg/ccr/job.go:2834
github.com/selectdb/ccr_syncer/pkg/ccr.(*Job).dbSync
    /home/wyxxxcat/ccr-syncer/pkg/ccr/job.go:2895
github.com/selectdb/ccr_syncer/pkg/ccr.(*Job).sync
    /home/wyxxxcat/ccr-syncer/pkg/ccr/job.go:2912
github.com/selectdb/ccr_syncer/pkg/ccr.(*Job).run
    /home/wyxxxcat/ccr-syncer/pkg/ccr/job.go:2970
github.com/selectdb/ccr_syncer/pkg/ccr.(*Job).Run
    /home/wyxxxcat/ccr-syncer/pkg/ccr/job.go:3091
github.com/selectdb/ccr_syncer/pkg/ccr.(*JobManager).runJob.func1
    /home/wyxxxcat/ccr-syncer/pkg/ccr/job_manager.go:166
runtime.goexit
    /usr/local/go/src/runtime/asm_amd64.s:1700 job=test line=ccr/job.go:2975

@dataroaring dataroaring left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@w41ter w41ter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the syntax definition about column default value:

opt_default_value ::=
    /* Empty */
    {:
        RESULT = ColumnDef.DefaultValue.NOT_SET;
    :}
    | KW_DEFAULT STRING_LITERAL:value
    {:
        RESULT = new ColumnDef.DefaultValue(true, value);
    :}
    | KW_DEFAULT KW_NULL
    {:
        RESULT = ColumnDef.DefaultValue.NULL_DEFAULT_VALUE;
    :}
    | KW_DEFAULT KW_CURRENT_TIMESTAMP
    {:
        RESULT = ColumnDef.DefaultValue.CURRENT_TIMESTAMP_DEFAULT_VALUE;
    :}
    | KW_DEFAULT KW_CURRENT_TIMESTAMP LPAREN INTEGER_LITERAL:precision RPAREN
    {:
        RESULT = ColumnDef.DefaultValue.currentTimeStampDefaultValueWithPrecision(precision);
    :}
    | KW_DEFAULT KW_BITMAP_EMPTY
    {:
        RESULT = ColumnDef.DefaultValue.BITMAP_EMPTY_DEFAULT_VALUE;
    :}
    | KW_DEFAULT INTEGER_LITERAL:value
    {:
        RESULT = new ColumnDef.DefaultValue(true, value);
    :}
    | KW_DEFAULT LARGE_INTEGER_LITERAL:value
    {:
        RESULT = new ColumnDef.DefaultValue(true, value);
    :}
    | KW_DEFAULT DECIMAL_LITERAL:value
    {:
        RESULT = new ColumnDef.DefaultValue(true, value);
    :}
    

Comment thread pkg/ccr/base/spec.go Outdated
@w41ter
w41ter merged commit 0968e29 into selectdb:dev Dec 16, 2024
w41ter added a commit that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants