Fixed bug that left a '-1' tabindex on a select after destroying selectize #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 28, 2013 17:10
…ctize Selectize sets a '-1' tabindex on the original select element when initialized. When the select element did not originally have a tabindex set, Selectize would not properly remove the '-1' tabindex when destroying itself.
Author
|
I had a feeling I was supposed to make a branch on my fork before making any changes... Whoops. |
added 2 commits
October 29, 2013 08:45
Because I just read the notes for contribution in the README.
brianreavis
added a commit
that referenced
this pull request
Nov 3, 2013
Fixed bug that left a '-1' tabindex on a select after destroying selectize
Member
|
Thanks! This is part of v0.8.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selectize sets
tabindex="-1"on the original select element when initialized. When the select element did not originally have the tabindex attribute set, Selectize would not properly remove the attribute when destroying itself.I believe I've modified all relevant files with a fix, and I've also included a unit test.