refactor(web): extract clipboard hook and item subcomponents from context-picker#764
Merged
Merged
Conversation
…text-picker Split context-picker.tsx (609 → 441 lines) by extracting: - use-context-picker-clipboard.ts (142 lines): all clipboard state, refs, and handlers (checkClipboard, pasteInput, pasteFeedback) into a custom hook - context-picker-items.tsx (85 lines): ContextFileItem and ContextLinkItem subcomponents for file thumbnail and link badge rendering Also deduplicated the popover content JSX that was repeated in both the empty-state and has-items branches. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Address architecture review feedback: rename stuttery hook return keys (e.g. clipboard.clipboardPasteMode → clipboard.pasteMode) since the clipboard namespace already provides context. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
use-context-picker-clipboard.ts(142 lines) — a custom hook encapsulating all clipboard-related state (4 useState, 3 useRef) and handlers (handleCheckClipboard,handleClipboardPasteInput,handleClipboardPasteBlur,handlePaste) fromcontext-picker.tsx.context-picker-items.tsx(85 lines) —ContextFileItemandContextLinkItemsubcomponents for file thumbnail and link badge rendering.popoverContentvariable.Result:
context-picker.tsxreduced from 609 → 441 lines. The component now has 3 useState hooks (down from 7) and the render tree is easier to follow.New file structure
Next run
changes-tab.tsx(893 lines) is queued as the next componentizer target.Test plan
pnpm run check:web)pnpm run build:web)🤖 Generated with Claude Code