Light up review agent rows and add a contextual tip once their review is ready#791
Merged
Conversation
When a review agent's review is submitted (the same condition that makes the row clickable), the sidebar row now gets a primary-tinted border and background, a filled Review badge, and full opacity even when stopped. A one-time contextual tip using the built-in TipSpot system anchors to the row, explaining that clicking it opens the review. TipSpot gains an optional triggerClassName so it can wrap block-level anchors like the row. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…r connected Persona review agt_315e90987a6a items #1156/#1157: the tip queue now tracks which TipSpot instance owns the active grant (via useId token), so multiple rows sharing one tipId show a single popover — this also covers the latent duplicate for split-tabs in center-pane-tab-bar. The review-ready row classes now come after isConnected so the lit treatment wins both resting and hover styles when a terminal is attached. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Reviewer-suggested hardening on feedback #1156: requestOpen previously read the active claim from a stale closure, so two TipSpot timers firing in the same tick could both see null and both win. The claim now lives in a ref checked synchronously; state remains only to re-trigger waiting TipSpot effects after a release. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When a review agent submits its review — the same
canOpenSubmittedReviewcondition that makes its sidebar row clickable — the row now:While the review is still in progress, nothing changes: no tip, no lit treatment — the existing chase animation continues to cover that state.
How
tips.ts: newreview-row-openinline tip (since: 0.29.1, so it surfaces for users upgrading to the next release)tip-spot.tsx: optionaltriggerClassNameprop so TipSpot can wrap block-level anchors like the row (flex w-full) without layout shiftchild-agent-row.tsx: ready-state styling +data-review-readyattribute; row is wrapped in TipSpot only when the review can be openedValidation
data-review-readyfollows the same gating as the click-throughpnpm run check,finalize:web, full E2E suite (168 passed), and web unit tests all green🤖 Generated with Claude Code