fix: close Didit SDK modal on 'In Review' status#1899
Conversation
When Didit returns 'In Review', the SDK shows its own pending screen that blocks the UI. Close the modal as soon as onComplete fires so our Socket.IO waiting flow can take over. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughTwo small UI and SDK lifecycle updates: the Didit SDK now closes immediately on the first terminal result, and the onboarding ProviderLaunchScreen separates waiting vs loading render paths and wires a KycPendingScreen with back and live-update handlers. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Replace the generic spinner with Euclid's KycPendingScreen when verification is under review. Shows animation, 'Check back later' and 'Receive live updates' buttons. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Superseded by #1900 — same changes rebased onto feat/stitch-screens-with-provingmachine |
Summary
onCompletefires, regardless of status'In Review', the SDK shows its own "Your submission is under review" screen that blocks the UI indefinitelyDiditSdk.shared.close()before emitting the result, our "Processing verification..." screen takes over and Socket.IO waits for the TEE webhookProblem
Didit SDK fires
onComplete({type: 'completed', session: {status: 'In Review'}})but keeps its modal visible, showing a pending screen. The user sees Didit's UI instead of ours, with no way to proceed until the review completes.Fix
Call
DiditSdk.shared.close()inemitOnce()before invoking the complete/error callback. This dismisses the modal so our waiting UI can show while Socket.IO subscribes and waits for the signed attestation.Test plan
Summary by CodeRabbit
New Features
Bug Fixes