Skip to content

fix: close Didit modal on completion, show KycPendingScreen#1900

Merged
seshanthS merged 1 commit intofeat/stitch-screens-with-provingmachinefrom
fix/didit-under-review-v2
Apr 1, 2026
Merged

fix: close Didit modal on completion, show KycPendingScreen#1900
seshanthS merged 1 commit intofeat/stitch-screens-with-provingmachinefrom
fix/didit-under-review-v2

Conversation

@Nesopie
Copy link
Copy Markdown
Collaborator

@Nesopie Nesopie commented Apr 1, 2026

Summary

  • Close the Didit SDK modal immediately when onComplete fires, regardless of status
  • Show Euclid's KycPendingScreen while Socket.IO waits for the TEE attestation
  • When Didit returns 'In Review', the SDK shows its own pending screen that blocks the UI — this fix dismisses it so our flow takes over

Changes

  • diditProvider.ts: Call DiditSdk.shared.close() in emitOnce() before callbacks
  • ProviderLaunchScreen.tsx: Replace spinner with KycPendingScreen for the waiting phase

Test plan

  • Didit modal closes after verification submission
  • KycPendingScreen shows while waiting for TEE attestation
  • Attestation arrives via Socket.IO after Didit approves
  • "Check back later" navigates back

…ting

- Close Didit SDK modal immediately when onComplete fires
- Show Euclid KycPendingScreen with animation while Socket.IO waits for TEE attestation
- Replaces generic spinner for the 'In Review' waiting state

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
self-webview-app Ready Ready Preview, Comment Apr 1, 2026 0:00am

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 1, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (3)
  • main
  • dev
  • staging

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6c66815e-e328-43db-a77a-e19f90d16a76

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/didit-under-review-v2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@seshanthS seshanthS merged commit c3b816a into feat/stitch-screens-with-provingmachine Apr 1, 2026
13 checks passed
@seshanthS seshanthS deleted the fix/didit-under-review-v2 branch April 1, 2026 12:09
transphorm added a commit that referenced this pull request Apr 1, 2026
* stitch tunnelflow screens

* save wip formatting

* add failure flow

* stub account recovery

* add tests

* add spec wv-17

* prep for review

* serialize

* fixes

* fix bug

* fix dev building

* fix: close Didit modal on completion, show KycPendingScreen while waiting (#1900)

- Close Didit SDK modal immediately when onComplete fires
- Show Euclid KycPendingScreen with animation while Socket.IO waits for TEE attestation
- Replaces generic spinner for the 'In Review' waiting state

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* navigate to disclose step on restore

* skip disclose confirmation screen

* Update Recovery flow

* Navigate to account recovery if TEE rejects it as already registered

* Navigate to disclose directly if the selected document is registered

* SELF-2348: Load webapp from url

* update sdk-test-app

* fix result from sdk

* fixes?

* fix build issue

* fix install pipeline

* carry pr feedback. fix formatting

---------

Co-authored-by: Justin Hernandez <justin.hernandez@self.xyz>
Co-authored-by: Nesopie <87437291+Nesopie@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants