Feed reviewers PR/MR description + linked-issue acceptance criteria (diffsmith-144) - #4
Merged
Merged
Conversation
…shapes (diffsmith-144)
…ontext notes on total failure, --no-context print-prompt tests (diffsmith-144)
selyafi
added a commit
that referenced
this pull request
Jun 11, 2026
…h-h7a) When every reviewer fails, contextNotes were sent as a PhaseStatusMsg one message before LoadErrorMsg — but the loader's error view renders only the error, and loader.Err() is what cobra prints on exit, so the notes vanished exactly when they help explain the failure. Join them into the aggregated error instead and drop the dead status send. Found by codex reviewing PR #4 during the diffsmith-ce8 verification run. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
# Intentsection before the diff — so a diff-only reviewer can flag scope drift and unmet criteria.review.LinkedIssueFetcherprovider capability: GitHub resolvesclosingIssuesReferences→gh issue view; GitLab usesglab api .../closes_issues. Description is captured for free insideFetch.--no-contextopts out entirely: withholds the description and skips the linked-issue fetch (no extra network).Test plan
go build ./... && go vet ./... && go test ./...— 444 tests pass--print-prompton live PRs: IFW #277 renders description + issue #247 acceptance criteria;--no-contextstrips it; ncspot #1716 (no linked issue) → description-only🤖 Generated with Claude Code