fix(weave): allow nested extraction sources without root knops - #31
Conversation
- assertCurrentMeshInventoryShapeForFirstExtractedKnopWeave no longer
demands a Knop, working inventory locator, and page for the source
payload's derived first path segment — a grouping path is not
automatically a managed Semantic Flow identifier; the actual source
payload/Knop and target-Knop assertions are unchanged
- remove the now-unused private toRootDesignatorPath helper
- regression: extracted-term weave from a nested source (alice/data)
with no alice/_knop facts, current-only support policies matching the
SRD failure arm; fail-on-old recorded ("settled extracted-knop
pre-weave mesh inventory shape"); asserts bob weaves, page claims
render, nested source facts survive, and no alice/_knop facts, files,
or pages are synthesized
- bite 1 of the extract→weave scale work in
wa.task.2026.2026-07-21_1603-extractor-defect-pair (Kim brief there);
full ci + build:npm-lib green
Implemented-By: Codex (codex exec) as Kim
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LHrFYeUefDr227gLuWWuq1
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughExtracted-Knop shape validation now uses the source payload’s Knop path directly. It requires source Knop artifacts unconditionally. A regression test covers nested weaving without root Knop artifacts. ChangesNested source Knop handling
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…sure rename, PR #31 boarded - flip the wd.todo requirements-collection checkbox (collection folded; note stays open only for the evidence-gated topology decision) - rename refs: wa.task.2026.2026-07-05-multi-target-payload-advancement -> wa.completed.* in wd.decision-log - read-in arc: PR #31 landed (merge GO with Dave), requirements folded, binary-payload task note still to cut - maintenance log: wake 2/3 harvests, closure rename, cd/absolute-path lesson Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LHrFYeUefDr227gLuWWuq1
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
- wd.todo: binary item points at wa.task.2026.2026-08-01_1411 (queue- blocked on the court's five spec adjudications) - maintenance log: harvest lines (binary note minted with the adjacent later-renderer RdfDocument typing defect; bite-2 fire; PR #31 all green incl. codecov/patch, CodeRabbit clean) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LHrFYeUefDr227gLuWWuq1
staged) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LHrFYeUefDr227gLuWWuq1
Bite 1 of the extract→weave scale work in
wa.task.2026.2026-07-21_1603-extractor-defect-pair(Kim brief in that note; carved and fired from planning-loop wakes 2–3).What
assertCurrentMeshInventoryShapeForFirstExtractedKnopWeavedemanded a Knop, working inventory locator, and ResourcePage for the source payload's derived first path segment — so a targetedfirstExtractedKnopWeavefrom a nested source likealice/datarefused whenever the namespace-likealicehad noalice/_knop. The corpus diagnosis isolated this as the immediate blocker at Stagecraft's ~1,700-term nested-source scale (adding only fictional root-Knop facts made validation pass). A grouping path is not automatically a managed Semantic Flow identifier: the derived-root requirements are removed, the actual source payload/Knop and target-Knop assertions are unchanged, and the deadtoRootDesignatorPathhelper is deleted.Evidence
WeaveInputError: The current local weave slice only supports the settled extracted-knop pre-weave mesh inventory shape for bob.alice/_knopfacts, files, or pages are synthesized.deno task cigreen;deno task build:npm-libgreen (dnt).Not in this bite (stays boarded on the task note)
Versioned nested-source behavior, untargeted/multi-target agreement, MeshInventory history-index rendering (the fixed
_s0001–_s0004list), heavy-mesh generator nested-source mode, the ~1,700-term regression workload, and any claim of full extract→weave→generate viability — the Stagecraft workaround does not retire yet.Implemented by Codex (
codex exec) as Kim under the standing loop-wake grant; reviewed, validated, and landed by the planning seat.🤖 Generated with Claude Code
https://claude.ai/code/session_01LHrFYeUefDr227gLuWWuq1
Summary by CodeRabbit
Bug Fixes
Tests