Report the reason when object creation fails - #99
Open
ramonski wants to merge 2 commits into
Open
Conversation
create_items caught each object's creation error, logged it, and then
raised a generic "No Objects could be created", discarding the useful
detail (for example the validation error {"field": "required field"}).
Collect the per-object errors and include them in the raised message so
callers see exactly what to fix instead of a generic failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
create_itemsnow includes the underlying error(s) in its response when nothing could be created, instead of the generic "No Objects could be created".Why
When an object failed to create,
create_itemscaught the exception, logged it, and raised a genericBadRequestError("No Objects could be created")— discarding the actual reason. For example, creating anAnalysisCategorywithout its requireddepartmentfield produced only:while the real cause was right there in the logs:
Callers (including agents driving the API) had to dig through server logs to find out which required fields were missing.
Change
create_itemscollects the per-object error messages and surfaces them in the raised error:The authoritative validation detail comes straight from SENAITE, so there is no duplicated list of required fields to maintain. Per-object savepoint rollback and the partial-success path (return whatever succeeded) are unchanged.
Stacking
Stacked on top of #98 (
feature/rest-verbs).