fix: escalate Claude companion network calls - #82
Merged
sf-jin-ku merged 2 commits intoJul 29, 2026
Conversation
Require targeted sandbox escalation when Codex launches the Claude companion so API DNS access is available without enabling network access globally. Add contract and end-to-end coverage for rescue, review, and adversarial review paths.\n\nRefs sendbird#81
sf-jin-ku
approved these changes
Jul 29, 2026
sf-jin-ku
left a comment
Contributor
There was a problem hiding this comment.
Reproduced the boundary: Codex's default workspace-write sandbox has no outbound network, so the companion starts Claude and then fails DNS. Scoping the escalation to the single companion exec_command (rather than telling users to enable global network_access) is the right narrow fix, and the contract + E2E assertions keep the forwarding children from regressing to use_default.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
require_escalatedsandbox permissions whenever Codex launches the Claude companionRoot cause
Codex's default
workspace-writesandbox does not provide network access. The built-in forwarding paths launchedclaude-companion.mjswithout requesting targeted escalation, so the Claude CLI could start but DNS resolution for the Claude API failed withENOTFOUND.The fix escalates only the companion shell call, with a narrowly scoped justification. It does not enable network access globally; Claude's own task/review sandbox and permission controls continue to govern repository access and mutations.
Validation
node --test tests/skills-contracts.test.mjs: 9 passed, 0 failedCC_NETWORK_OKnpm run check:git diff --check: cleanCloses #81