fix: shell-quote each SSH arg in the attach retry script - #145
Merged
Conversation
The retry wrapper script joined sshArgs with spaces, but the args contain spaces themselves (the tmux command with quotes). The shell split them incorrectly: "ssh -t host sh -c tmux new-session ..." became "ssh -t host sh -c tmux" (sh -c only gets "tmux", losing the rest). Each arg is now individually shell-quoted so the script passes the full tmux command string intact to the remote sh -c.
Kairo-Kim
approved these changes
Jul 25, 2026
Kairo-Kim
added
the
auto-review/approved
mitrilmad
approved these changes
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enter on a remote SSH session went to a plain SSH shell instead of attaching to the remote tmux session running Claude.
Root cause: the retry wrapper script joined sshArgs with spaces, but the args contain spaces themselves (the tmux command with quotes). The shell split them incorrectly:
ssh -t host sh -c tmux new-session ...becamessh -t host sh -c tmux(sh -c only gets "tmux", losing the rest of the command).Fix: each ssh arg is now individually shell-quoted so the script passes the full tmux command string intact to the remote sh -c.
go build/vet clean.