Add lock to Pubsub.execute_command to ensure only one connection is created#19
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19 +/- ##
==========================================
- Coverage 92.40% 92.36% -0.04%
==========================================
Files 119 119
Lines 30727 30743 +16
==========================================
+ Hits 28392 28395 +3
- Misses 2335 2348 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
is it better patch it upstream? |
it would be best to patch the upstream as well as we can remove this PR once upstream release a new release Also could you please add a test case for this code (ex. lock is already acquired and trying to acquire a connection doesn't return a new connection)? |
zach-iee
left a comment
There was a problem hiding this comment.
i'll review again, when a test is added
|
@dlunch any update? |
|
Sorry, i was on vacation. i'll add test this week |
fa27fe9 to
3fc64f2
Compare
zach-iee
left a comment
There was a problem hiding this comment.
👍
please create a PR to 4.4 branch in order to backmerge
…reated (#19) * Add lock to Pubsub.execute_command to ensure only one connection is created * Add tests
Pull Request check-list
Please make sure to review and check all of these items:
$ toxpass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.