Skip to content

Conversation

@AhyoungRyu
Copy link
Contributor

Fixes https://sendbird.atlassian.net/browse/SBISSUE-17702

  • Fix Object.assign order to allow proper parameter override
  • Add test case to verify localCacheEnabled override

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If unsure, ask the members.
This is a reminder of what we look for before merging your code.

  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • Public components / utils / props are appropriately exported
  • I have added necessary documentation (if appropriate)

@AhyoungRyu AhyoungRyu self-assigned this Nov 6, 2024
@netlify
Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for sendbird-uikit-react ready!

Name Link
🔨 Latest commit 3581646
🔍 Latest deploy log https://app.netlify.com/sites/sendbird-uikit-react/deploys/672c0dff26dd0d00081e963c
😎 Deploy Preview https://deploy-preview-1248--sendbird-uikit-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AhyoungRyu AhyoungRyu merged commit 0673f0b into main Nov 7, 2024
10 checks passed
@AhyoungRyu AhyoungRyu deleted the feat/SBISSUE-17702 branch November 7, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants