Skip to content

[CLNP-5591] Allow localCacheEnabled override through sdkInitParams #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2024
Merged

[CLNP-5591] Allow localCacheEnabled override through sdkInitParams #1248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9de9ad3
allow localCacheEnabled override through sdkInitParams
AhyoungRyu Nov 7, 2024
3581646
Fix lint
AhyoungRyu Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions src/lib/hooks/useConnect/__test__/setupConnection.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,4 +265,27 @@ describe('useConnect/setupConnection/initSDK', () => {
});
expect(newSdk).toEqual(mockSdk);
});
it('should override default localCacheEnabled when provided in sdkInitParams', async () => {
const setUpConnectionProps = generateSetUpConnectionParams();
const { appId } = setUpConnectionProps;
const sdkInitParams = {
localCacheEnabled: false,
};

const newSdk = initSDK({ appId, sdkInitParams });

// @ts-ignore
expect(require('@sendbird/chat').init).toBeCalledWith({
appId,
newInstance: false,
modules: [
// @ts-ignore
new (require('@sendbird/chat/groupChannel').GroupChannelModule)(),
// @ts-ignore
new (require('@sendbird/chat/openChannel').OpenChannelModule)(),
],
localCacheEnabled: false,
});
expect(newSdk).toEqual(mockSdk);
});
});
5 changes: 3 additions & 2 deletions src/lib/hooks/useConnect/setupConnection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,12 +173,13 @@ export function initSDK({
sdkInitParams?: SendbirdChatInitParams;
customExtensionParams?: CustomExtensionParams;
}) {
const params = Object.assign(sdkInitParams, {
// eslint-disable-next-line prefer-object-spread -- not to break the existing types
const params = Object.assign({}, {
appId,
modules: [new GroupChannelModule(), new OpenChannelModule()],
newInstance: isNewApp,
localCacheEnabled: true,
});
}, sdkInitParams);

if (customApiHost) params.customApiHost = customApiHost;
if (customWebSocketHost) params.customWebSocketHost = customWebSocketHost;
Expand Down