Skip to content

fix(panes): restore lens split borders - #380

Merged
astyfx merged 1 commit into
mainfrom
fix/lens-panel-border
Aug 14, 2026
Merged

fix(panes): restore lens split borders#380
astyfx merged 1 commit into
mainfrom
fix/lens-panel-border

Conversation

@astyfx

@astyfx astyfx commented Aug 14, 2026

Copy link
Copy Markdown
Member

Summary

Restore the Lens split border and resize sash across the full panel height when a native browser surface covers Dockview content.

Changes

Fixes

  • panes: derive Lens gutter edges from the full nested Dockview split chain.
  • panes: reserve a 2px renderer-owned gutter on both the Dockview view and its overlay content wrapper.
  • panes: keep the Lens page background visible through the reserved gutter.

Refactors / Chores

  • tests: cover nested gutter edge resolution and the rendered Lens placeholder inset.

Test Evidence

  • bun run test:ci — passed license, reliability, documentation path, max-lines, switch-exhaustiveness, typecheck, 422 isolated tests, renderer build, and desktop build gates.
  • bun run test:e2e -- tests/e2e/lens-workspace-switch.e2e.ts — passed.
  • Focused Lens/pane tests — 23 passed.

Notes

  • No breaking changes.
  • The gutter width remains centralized in --lens-split-gutter and uses existing theme tokens for the surrounding surfaces and separator.

@astyfx
astyfx requested a review from a team as a code owner August 14, 2026 08:06
@astyfx
astyfx requested review from heath-s and png-1105 and removed request for a team August 14, 2026 08:06
@astyfx
astyfx enabled auto-merge (squash) August 14, 2026 08:06
@upwind-code-us

upwind-code-us Bot commented Aug 14, 2026

Copy link
Copy Markdown

Upwind Upwind Code Scan - ✅ Proceed with Deployment

0 newly introduced vulnerabilities · 0 resolved · 80 total in this PR vs main

🔴 1 Critical | 🔶 27 High | 🟡 49 Medium | 🟢 3 Low

View full analysis in Upwind Console

Scan completed in 8m 54s

Scan history (1 scan)
Commit Scanned at New Resolved Net
6dc1eeb < 2026-08-14 08:07 UTC 0 0 0

Last scanned: 6dc1eeb · 2026-08-14 08:07 UTC

@upwind-code-us

upwind-code-us Bot commented Aug 14, 2026

Copy link
Copy Markdown

Upwind Upwind IaC Scan - ✅ Proceed with Deployment

0 newly introduced misconfigurations · 0 resolved · 0 total in this PR vs main

View full analysis in Upwind Console →

Scan completed in 3m 50s

Scan history (1 scan)
Commit Scanned at New Resolved Net
6dc1eeb < 2026-08-14 08:07 UTC 0 0 0

Last scanned: 6dc1eeb · 2026-08-14 08:07 UTC

@heath-s heath-s left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@astyfx
astyfx merged commit 4d1c44d into main Aug 14, 2026
4 checks passed
@astyfx
astyfx deleted the fix/lens-panel-border branch August 14, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants