Update nodejs-http-client dependency to v2.3.0, closes #317 #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkingserious
requested changes
Oct 14, 2016
| console.log(response.statusCode) | ||
| console.log(response.body) | ||
| console.log(response.headers) | ||
|
|
Contributor
There was a problem hiding this comment.
I would also like to keep the logging of the response in the case of no error for demonstration purposes. Could you please add that back in? Perhaps just add an else. Thanks!
Contributor
Author
There was a problem hiding this comment.
Good idea!
I have already committed the new code, which include the else part.
Thanks.
thinkingserious
added
type: community enhancement
thinkingserious
approved these changes
Oct 14, 2016
Contributor
|
Hi @aszx87410, Please take a moment to fill out this form so we can send you some swag :) |
thinkingserious
added a commit
that referenced
this pull request
Oct 14, 2016
…back with a mocked response upon Error
Contributor
Author
|
Hi @thinkingserious, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update TROUBLESHOOTING.md, adding code to log error message.