fix(worker): stop calling every probe a startup probe in the log - #15
Merged
Conversation
Caught on the live agent minutes after deploying 0.4.0: a probe triggered by the cmd topic logged 'startup probe: printer did not answer', which reads as though the service had just restarted. An operator tailing the journal would go looking for a crash. Same staleness as the docstring fixed in #14 and from the same cause -- the message was written when startup was the only caller, and #14 added two more. Dropped the qualifier rather than threading the trigger through, since the line is about the printer not answering and which caller asked adds nothing to that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caught on the live agent minutes after deploying 0.4.0. A probe triggered by the
cmdtopic logged:The service had not restarted — someone pressed refresh. An operator tailing the journal would go looking for a crash that never happened.
Same staleness as the
probe_devicedocstring fixed in #14, and from the same cause: the message was written when startup was the only caller, and #14 added two more (the idle tick and theprobecommand).Dropped the qualifier rather than threading the trigger through. The line is about the printer not answering, and which caller asked adds nothing to that. Same for the
_PROBE_SETTLE_Scomment.274 tests, ruff clean.