Skip to content

test(trie): cover canonical-delete branches and fork gate#825

Merged
github-actions[bot] merged 1 commit into
mainfrom
test/canonical-delete-coverage
Jun 21, 2026
Merged

test(trie): cover canonical-delete branches and fork gate#825
github-actions[bot] merged 1 commit into
mainfrom
test/canonical-delete-coverage

Conversation

@satyakwok

Copy link
Copy Markdown
Member

Follow-up to #823. These tests were written for the canonical-SMT-delete fix but landed after #823 had already auto-merged (the merge happened before branch protection / required codecov/patch existed), so they never made it into main.

Covers the new code paths in #823:

  • delete-to-empty returns the canonical empty root
  • deleting a key whose sibling is a multi-key internal subtree leaves the remaining keys exactly as a direct insert (the non-pull-up branch)
  • get_/is_canonical_delete_height default-off + pinned activation (>= boundary)
  • Blockchain::is_canonical_delete_height wrapper default-off

Test-only; no behaviour change.

…/patch

Adds tests for the new code paths so the patch clears the 80% coverage gate:
- delete-to-empty returns the canonical empty root
- deleting a key whose sibling is a multi-key internal subtree leaves the
  remaining keys exactly as a direct insert (the non-pull-up branch)
- fork-heights get_/is_canonical_delete_height default-off + pinned activation
- Blockchain::is_canonical_delete_height wrapper default-off
@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@satyakwok, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 55 minutes and 5 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 12fb01d1-108a-434c-abc0-53f0931abbb0

📥 Commits

Reviewing files that changed from the base of the PR and between e0f3573 and 0cc364e.

📒 Files selected for processing (3)
  • crates/sentrix-core/src/blockchain.rs
  • crates/sentrix-fork-heights/src/lib.rs
  • crates/sentrix-trie/tests/delete_canonical_repro.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/canonical-delete-coverage

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot enabled auto-merge (squash) June 21, 2026 03:36
@codecov

codecov Bot commented Jun 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions github-actions Bot merged commit ed98f4e into main Jun 21, 2026
19 checks passed
@satyakwok satyakwok deleted the test/canonical-delete-coverage branch June 21, 2026 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant