Ensure that any error path out of doPodcastDownload sets status#672
Merged
Conversation
sentriz
reviewed
Mar 11, 2026
Comment on lines
+527
to
+530
| // We set err = fmt.Errorf() instead of just returning it to make sure the defered | ||
| // function to set the podcast status to "error" runs on the way out | ||
| err = fmt.Errorf("fetch podcast audio: unexpected status %s", resp.Status) | ||
| return err |
Owner
There was a problem hiding this comment.
hey, you should be able to return it just fine. go will assign whats returned to "err" automatically
see https://go.dev/play/p/IttjQGAqQxs
Suggested change
| // We set err = fmt.Errorf() instead of just returning it to make sure the defered | |
| // function to set the podcast status to "error" runs on the way out | |
| err = fmt.Errorf("fetch podcast audio: unexpected status %s", resp.Status) | |
| return err | |
| return fmt.Errorf("fetch podcast audio: unexpected status %s", resp.Status) | |
Contributor
Author
There was a problem hiding this comment.
Thanks!
I will update the PR shortly.
Some error paths out of this function are not setting the podcast status to 'error'. Move the deferred error checking earlier to ensure the status is set. Signed-off-by: Eric B Munson <eric@munsonfam.org>
yaemiku
pushed a commit
to yaemiku/gonic
that referenced
this pull request
Apr 26, 2026
…ts status (sentriz#672) Some error paths out of this function are not setting the podcast status to 'error'. Move the deferred error checking earlier to ensure the status is set. Signed-off-by: Eric B Munson <eric@munsonfam.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some error paths out of this function are not setting the podcast status to 'error'. Move the deferred error checking earlier to ensure the status is set.