Skip to content

Conversation

@marehr
Copy link
Member

@marehr marehr commented Feb 21, 2018

Fix doxygen warnings that are not due to being undocumented.

Replace `\defgroup alphabet` with `\defgroup alphabet Alphabet`
```terminal
perl -i -p -e 's/(^.+\\defgroup )(\w)(\w+)($)/\1\2\3 \U\2\E\3\4/g;' **/*.hpp
```
/seqan3/include/seqan3/alphabet/aminoacid/all.hpp:35: warning: the name
`all.hpp' supplied as the second argument in the \file statement matches
the following input files:
   /seqan3/include/seqan3/alphabet/adaptation/all.hpp
   /seqan3/include/seqan3/alphabet/all.hpp
   /seqan3/include/seqan3/alphabet/aminoacid/all.hpp
   /seqan3/include/seqan3/alphabet/composition/all.hpp
   /seqan3/include/seqan3/alphabet/gap/all.hpp
   /seqan3/include/seqan3/alphabet/nucleotide/all.hpp
   /seqan3/include/seqan3/alphabet/quality/all.hpp
   /seqan3/include/seqan3/alphabet/structure/all.hpp

Remove optional argument behind \file

```terminal
perl -i -p -e 's/(^.+\\file)(.+)($)/\1\3/g;' **/*.hpp
```
…between _

warning: unable to resolve link to `operator""_dna5' for \link command

```terminal
perl -i -p -e 's/(operator) ("") (_\w+)/\1\2\3/g;' **/*.hpp
```
…assumed class-members

/seqan3/include/seqan3/alphabet/nucleotide/all.hpp:252: warning:
explicit link request to 'A' could not be resolved
/seqan3/include/seqan3/alphabet/nucleotide/all.hpp:252: warning:
explicit link request to 'C' could not be resolved
/seqan3/include/seqan3/alphabet/nucleotide/all.hpp:252: warning:
explicit link request to 'G' could not be resolved
/seqan3/include/seqan3/alphabet/nucleotide/all.hpp:252: warning:
explicit link request to 'T' could not be resolved
/seqan3/include/seqan3/alphabet/nucleotide/all.hpp:252: warning:
explicit link request to 'U' could not be resolved
/seqan3/include/seqan3/alphabet/nucleotide/all.hpp:252: warning:
explicit link request to 'UNKNOWN' could not be resolved
/seqan3/include/seqan3/alphabet/nucleotide/all.hpp:334: warning:
explicit link request to 'T' could not be resolved
/seqan3/include/seqan3/alphabet/nucleotide/all.hpp:334: warning:
explicit link request to 'U' could not be resolved
This is now auto-linkable:
```c++
template <typename semi_alphabet_type>
using underlying_rank_t = typenam underlying_rank<semi_alphabet_type>::type;
```

This example is still not able to auto-link:
```c++
template <typename alphabet_type>
//!\cond
    requires requires (alphabet_type alph) {alphabet_size<alphabet_type>::value; }
//!\endcond
constexpr auto alphabet_size_v = alphabet_size<alphabet_type>::value;
```

Fixes warnings:

/seqan3/include/seqan3/alphabet/concept_pre.hpp:167: warning: explicit link request to 'type' could not be resolved
/seqan3/include/seqan3/alphabet/concept_pre.hpp:79: warning: explicit link request to 'type' could not be resolved
/seqan3/include/seqan3/alphabet/concept_pre.hpp:80: warning: unable to resolve link to `seqan3::underlying_rank_t<>' for \link command
/seqan3/include/seqan3/alphabet/gap/gap.hpp:100: warning: argument 'c'
of command @param is not found in the argument list of
seqan3::gap::assign_char(char_type const)
/seqan3/include/seqan3/range/container/concatenated_sequences.hpp:227: warning: argument 'count' of command @param is not found in the argument list of seqan3::concatenated_sequences< inner_type, data_delimiters_type >::concatenated_sequences(rng_of_rng_type &&rng_of_rng)
/seqan3/include/seqan3/range/container/concatenated_sequences.hpp:227: warning: argument 'value' of command @param is not found in the argument list of seqan3::concatenated_sequences< inner_type, data_delimiters_type >::concatenated_sequences(rng_of_rng_type &&rng_of_rng)
/seqan3/include/seqan3/range/container/concatenated_sequences.hpp:345: warning: argument 'count' of command @param is not found in the argument list of seqan3::concatenated_sequences< inner_type, data_delimiters_type >::assign(rng_of_rng_type &&rng_of_rng)
/seqan3/include/seqan3/range/container/concatenated_sequences.hpp:345: warning: argument 'value' of command @param is not found in the argument list of seqan3::concatenated_sequences< inner_type, data_delimiters_type >::assign(rng_of_rng_type &&rng_of_rng)
/include/seqan3/range/view/trim.hpp:117: warning: Found ';' while
parsing initializer list! (doxygen could be confused by a macro call
without semicolon)
@marehr
Copy link
Member Author

marehr commented Feb 21, 2018

Remaining open issues:

  • /seqan3/include/seqan3/io/alignment/align_file_detail.hpp:137: warning: documented symbol `void seqan3::detail::align_file< index >::select_format' was not declared or defined.
  • /seqan3/include/seqan3/io/sequence/sequence_file_in.hpp:170: warning: documented symbol `void seqan3::sequence_file_in< index >::select_format' was not declared or defined. (@rrahn these files are broken, right? So no attempt to fix this.)
  • /seqan3/include/seqan3/range/container/concatenated_sequences.hpp:1310: warning: unable to resolve reference to `serialisation' for \ref command (@h-2 do we have a \section about serialisation in our documentation? If not the \ref does not make sense.

This is ready to be merged from my pow.

@marehr
Copy link
Member Author

marehr commented Feb 22, 2018

!rebuild

Copy link
Contributor

@rrahn rrahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rrahn rrahn merged commit 5404a17 into seqan:master Feb 22, 2018
@marehr marehr mentioned this pull request Feb 22, 2018
@marehr marehr deleted the fix_doxygen_warnings branch February 22, 2018 23:09
This was referenced Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants