Skip to content

Fix CI: remove docker-practice/actions-setup-docker@master#30

Merged
cokelaer merged 3 commits intomainfrom
copilot/update-github-workflows
Mar 21, 2026
Merged

Fix CI: remove docker-practice/actions-setup-docker@master#30
cokelaer merged 3 commits intomainfrom
copilot/update-github-workflows

Conversation

Copy link
Contributor

Copilot AI commented Mar 21, 2026

  • Remove failing docker-practice/actions-setup-docker@master step from .github/workflows/main.yml
  • Fix Python 3.8 compatibility: replace str.removeprefix() (Python 3.9+) with equivalent slice in versionix/parser.py

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Update GitHub workflows to fix CI failures Fix CI: remove docker-practice/actions-setup-docker@master Mar 21, 2026
Copilot AI requested a review from cokelaer March 21, 2026 13:57
Copy link
Contributor

@cokelaer cokelaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Copilot AI commented Mar 21, 2026

works for py39 to 3.12.
it fails for python 3.8: https://github.com/sequana/versionix/actions/runs/23381195731/job/68020835557?pr=30

Fixed in edc24bcstr.removeprefix() was introduced in Python 3.9, so it fails on 3.8. Replaced it with an equivalent slice expression (container[len("docker://"):]) that works on all supported Python versions.

Copilot AI requested a review from cokelaer March 21, 2026 14:03
@cokelaer cokelaer marked this pull request as ready for review March 21, 2026 14:25
@cokelaer cokelaer merged commit ac6f1cd into main Mar 21, 2026
5 checks passed
@cokelaer cokelaer deleted the copilot/update-github-workflows branch March 21, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants