Package for PyPI and support BCL Convert (v2) sample sheets#2
Merged
Conversation
- Move app.py, examples/, imgs/ into a check_my_sample_sheet package - Resolve packaged assets (logo, examples) via __file__ instead of cwd - Add __main__.py console entry point (check-my-sample-sheet) launching streamlit - Replace pytest-only pyproject.toml with full poetry metadata + build-system and a check-my-sample-sheet script entry point - Auto-detect v1 (bcl2fastq) vs v2 (BCL Convert) sheets via sequana SampleSheetFactory/get_sample_sheet_version; add a v2 example and load button - Reset the file_uploader when an example is loaded so a previously uploaded file no longer takes precedence - Rename UI title to "Check My Sample Sheet" - Require sequana>=0.23.0 (ships BCLConvert); add requests dependency - Update tests for the new package layout and README with install/usage 🤖 Generated with [Claude Code](https://claude.com/claude-code)
cokelaer
added a commit
that referenced
this pull request
Jul 3, 2026
Package for PyPI and support BCL Convert (v2) sample sheets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_my_sample_sheet/package with acheck-my-sample-sheetconsole entry point (launchesstreamlit run).pyproject.tomlwith full poetry metadata + build-system so a wheel/sdist can be published to PyPI.SampleSheetFactory/get_sample_sheet_version; add a v2 example + load button.sequana>=0.23.0(shipsBCLConvert); addrequestsdependency.Layout
Assets (
examples/,imgs/) moved into the package and resolved via__file__(cwd-independent). Verified the wheel ships all examples + logo + console script.Tests
pytest— 13 passed.poetry buildproduces sdist + wheel.Follow-ups (not in this PR)
check_my_sample_sheet/app.py(wasapp.py).🤖 Generated with Claude Code