Conversation
…ng migration file.
Member
|
I think the proposed API looks good, I like that better than specifying each attribute with a flag :) |
Member
There was a problem hiding this comment.
While this code is pretty readable and simple, I wonder if it wouldn't better to use some kind of templating language for the skeleton where we just insert tableName and attributes?
Member
Author
There was a problem hiding this comment.
that is really true and will be done in an upcoming PR. i thought exactly the same, but didn't want to do it within that PR as it is already quite big
Member
Author
|
@janmeier @mickhansen can you merge it ? :) |
Member
|
sure can ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
sequelize model:createwhich generates a model and it corresponding migration file.This task generates a model file and its respective migration.
It is necessary to specify the name of the new model as well as
the model's attributes.
The attributes can be specified as in the following (and semantically equal) examples:
This command will generate a new migration and model definition:
Discussion area:
I wonder if the API is OK or if there would be a better syntax for the attributes.